zopefoundation / zope.interface / 24229238372

99%

push

github

Guard 4 unprotected PyErr_Clear calls with exception type checks (#365)

Four PyErr_Clear() calls in implementedBy and providedBy clear
exceptions unconditionally, silently swallowing KeyboardInterrupt,
MemoryError, and SystemExit. The same file already has 7 correctly
guarded sites using PyErr_ExceptionMatches — these 4 were missed.

Sites fixed:
- implementedBy line 2436: guard with PyExc_AttributeError
- implementedBy line 2454: guard with PyExc_KeyError
- providedBy line 2601: guard with PyExc_AttributeError
- providedBy line 2615: guard with PyExc_AttributeError

Fixes #358

2438 of 2468 branches covered (98.78%)

Branch coverage included in aggregate %.

8 of 9 new or added lines in 1 file covered. (88.89%)

12169 of 12280 relevant lines covered (99.1%)

7.92 hits per line