• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

systemd / systemd / 24219823122
73%

Build:
DEFAULT BRANCH: main
Ran 10 Apr 2026 02:58AM UTC
Jobs 1
Files 2023
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Apr 2026 09:05PM UTC coverage: 72.373% (+0.07%) from 72.303%
24219823122

push

github

bluca
sd-varlink: fix a potential connection count leak

With the old version there was a potential connection count leak if
either of the two hashmap operations in count_connection() failed. In
that case we'd return from sd_varlink_server_add_connection_pair()
_before_ attached the sd_varlink_server object to an sd_varlink object,
and since varlink_detach_server() is the only place where the connection
counter is decremented (called through sd_varlink_close() in various
error paths later _if_ the "server" object is not null, i.e. attached to
the sd_varlink object) we'd "leak" a connection every time this
happened. However, the potential of abusing this is very theoretical,
as one would need to hit OOM every time either of the hashmap operations
was executed for a while before exhausting the connection limit.

Let's just increment the connection counter after any potential error
path, so we don't have to deal with potential rollbacks.

1 of 1 new or added line in 1 file covered. (100.0%)

5260 existing lines in 75 files now uncovered.

320514 of 442866 relevant lines covered (72.37%)

1186920.87 hits per line

Coverage Regressions

Lines Coverage ∆ File
536
69.71
0.12% src/core/exec-invoke.c
433
75.0
0.25% src/core/execute-serialize.c
409
79.65
-1.8% src/core/manager.c
407
80.58
-0.24% src/core/unit.c
403
83.52
0.07% src/libsystemd/sd-event/sd-event.c
380
75.64
0.66% src/core/cgroup.c
370
80.64
-0.06% src/libsystemd/sd-varlink/sd-varlink.c
325
28.37
-0.12% src/core/dbus-cgroup.c
321
58.01
0.0% src/core/main.c
270
41.96
0.0% src/import/pull-oci.c
147
69.41
-9.25% src/varlinkctl/varlinkctl.c
107
65.98
0.0% src/import/pull-raw.c
98
47.74
-1.25% src/vconsole/vconsole-setup.c
87
63.6
0.0% src/import/pull-job.c
81
60.11
0.0% src/import/pull-common.c
79
90.3
-0.54% src/libsystemd/sd-varlink/sd-varlink-idl.c
78
91.97
2.12% src/basic/compress.c
77
72.07
0.0% src/import/pull-tar.c
52
5.15
0.35% src/import/qcow2-util.c
52
34.66
-11.48% src/udev/udev-builtin-path_id.c
44
76.45
0.0% src/import/import-raw.c
38
75.94
0.0% src/import/import-common.c
37
51.83
0.0% src/core/varlink-manager.c
37
72.19
3.67% src/import/export.c
34
65.69
-1.12% src/core/service.c
30
73.99
0.0% src/import/export-tar.c
28
72.93
0.0% src/shared/bus-unit-util.c
27
80.8
0.0% src/core/varlink-cgroup.c
27
81.95
0.0% src/import/import-tar.c
24
62.01
-1.25% src/core/socket.c
21
79.19
0.0% src/import/export-raw.c
16
94.37
-2.21% src/test/test-compress.c
16
79.16
-0.91% src/udev/udev-rules.c
14
60.0
2.86% src/basic/confidential-virt.c
13
77.48
-1.24% src/core/job.c
13
81.77
-1.58% src/resolve/resolved-link.c
9
64.06
-1.23% src/libsystemd/sd-journal/journal-verify.c
9
85.02
-0.25% src/network/networkd-link.c
9
63.65
-1.6% src/shared/loop-util.c
9
98.39
-0.05% src/test/test-varlink.c
8
54.1
0.47% src/core/dbus-manager.c
8
90.91
-0.95% src/test/test-compress-benchmark.c
8
57.93
-1.34% src/timesync/timesyncd-manager.c
6
72.13
-1.64% src/udev/udev-watch.c
5
76.5
-0.91% src/core/timer.c
5
68.51
-2.76% src/import/import-fs.c
4
75.0
-0.67% src/core/transaction.c
4
40.43
-0.19% src/login/logind-dbus.c
4
98.72
0.0% src/resolve/test-dns-cache.c
3
75.0
-2.68% src/coredump/coredump-vacuum.c
3
73.88
-0.25% src/core/mount.c
3
93.62
-6.38% src/core/unit.h
2
96.88
0.05% src/basic/psi-util.c
2
92.86
-7.14% src/core/cgroup.h
2
83.05
0.0% src/core/path.c
2
79.11
-1.27% src/journal/journald-sync.c
2
75.68
-0.09% src/libsystemd/sd-bus/sd-bus.c
2
77.42
-0.4% src/login/logind-user.c
2
71.16
-0.12% src/resolve/resolved-dns-scope.c
2
78.82
-0.12% src/resolve/resolved-dns-transaction.c
2
48.8
-1.2% src/shared/machine-register.c
1
69.64
1.79% src/core/dbus-job.c
1
82.37
-0.32% src/journal/journalctl-show.c
1
79.25
0.38% src/journal-remote/journal-upload-journal.c
1
92.32
0.0% src/libsystemd/sd-journal/journal-file.c
1
72.0
-0.57% src/login/logind-varlink.c
1
87.92
-0.08% src/network/networkd-address.c
1
83.83
-0.12% src/network/networkd-dhcp-prefix-delegation.c
1
83.92
0.09% src/network/networkd-route.c
1
87.39
-0.23% src/network/tc/qdisc.c
1
81.46
-0.23% src/resolve/resolved-hook.c
1
68.18
-1.52% src/shared/module-util.c
1
94.09
-0.1% src/test/test-time-util.c
1
68.87
-0.04% src/tmpfiles/tmpfiles.c
1
28.61
-0.13% src/udev/udev-builtin-net_id.c
Jobs
ID Job ID Ran Files Coverage
1 24219823122.1 10 Apr 2026 02:57AM UTC 2023
72.37
GitHub Action Run
Source Files on build 24219823122
  • Tree
  • List 2023
  • Changed 121
  • Source Changed 54
  • Coverage Changed 109
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #24219823122
  • d3a1710b on github
  • Prev Build on main (#24165447443)
  • Next Build on main (#24269992631)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc