nestjs / nest / 9250dba8-55e7-4609-9bbe-e5a9e3a076a6

90%

master: 90%

Build Type

Pull #16753

circleci

Committed by jkalberer

Commit Message

fix(core): defer sse writehead until first message

When using @Sse() endpoints with ValidationPipe, pipe errors
(e.g. BadRequestException) were returned with HTTP 200 because
SseStream.pipe() eagerly called writeHead(200) before the
Observable had a chance to error. Exception filters could not
override the status code.

This PR defers header commitment in SseStream until the first
message is written via _transform(). If the Observable errors
before any data is emitted, the error propagates through the
exception filter which can now set the correct HTTP status.

- SseStream: lazy writeHead via commitHeaders()
- SseStream: LazyOrValue<T> for statusCode/additionalHeaders
- RouterResponseController: sse() Promise wrapper with
  catchError re-throw when headers uncommitted
- RouterExecutionContext: lazy getters for status/headers
- Integration tests for Express and Fastify (400 on pipe error)

Pull Request Pull Request #16753: fix(core): defer sse writehead until first message

Coverage Stats

2328 of 2872 branches covered (81.06%)

49 of 56 new or added lines in 3 files covered. (87.5%)

1 existing line in 1 file now uncovered.

7633 of 8492 relevant lines covered (89.88%)

21.17 hits per line