gnosisguild / zodiac-modifier-roles / 24214884837

96%

push

github

fix: add buffer to order validDuration to make it instantly valid (#475)

* fix: add buffer to order validDuration to make it instantly valid

Dishonest valid duration checks if block.timestamp + validDuration > order.validTo
but because we compute validDuration as validTo - Date.now() this simplifies to block.timestamp > Date.now()
block.timestamp might be behind Date.now() (when sending transaction it's verified against "latest" block).
This means that signOrder would reject unless we wait some time for block.timestamp to advance.
Adding buffer here (5 minutes) to ensure signature is immediately valid when generated.

References:
https://github.com/gnosisguild/cow-order-signer/blob/1fc456e11/contracts/CowswapOrderSigner.sol#L46-L49

* chore: reduce buffer to 15 seconds

It should be enough to cover most block times (12 seconds on mainnet)
with extra buffer on top.

401 of 414 branches covered (96.86%)

Branch coverage included in aggregate %.

695 of 732 relevant lines covered (94.95%)

234.66 hits per line