stacklok / toolhive / 24203869826

66%

Build Type

push

github

Committed by web-flow

Commit Message

Add vMCP MCPServerEntry static backend support (#4707)

* Add vMCP MCPServerEntry static backend support

Enable vMCP static mode to parse and connect to MCPServerEntry-type
backends from ConfigMap configuration, routing MCP traffic directly to
remote servers without proxy pods.

- Add BackendType constants (container, proxy, entry) to vmcp types
- Extend StaticBackendConfig with Type and CABundlePath fields
- Propagate entry backend fields through discoverer to Backend
- Add custom CA bundle support to HTTP client transport (per-backend)
- Add config validation for entry backend type and CA bundle paths
- Add unit tests for all new functionality (19 test cases)

Closes #4658

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review feedback: harden path validation and TLS config

- Strengthen CA bundle path validation with null byte check,
  path traversal rejection, and absolute path requirement to match
  existing patterns in pkg/git/client.go and pkg/server/discovery/
- Clone TLS config instead of replacing it to preserve existing
  settings (e.g. NextProtos for HTTP/2 ALPN) from the cloned transport
- Add backward-compatibility comments to unused BackendType constants
- Add test cases for null bytes and relative paths in CA bundle path

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove duplicate CABundlePath from StaticBackendConfig

Main gained a CABundlePath field (after Metadata) via #4698 while this
branch added one (before Metadata, alongside Type). Remove the duplicate
to fix the build.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate CRD manifests and API docs

Update VirtualMCPServer CRD schema to include the new Type field on
StaticBackendConfig. Regenerated with task operator-manifests and
task crdref-gen.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

45 of 69 new or added lines in 4 files covered. (65.22%)

36 existing lines in 4 files now uncovered.

56138 of 86355 relevant lines covered (65.01%)

61.48 hits per line