umputun / revdiff / 24200475888

87%

push

github

fix: load staged diff content for staged-only files in default mode (#80)

* fix: load staged diff content for staged-only files in default mode

Staged-only files (new files added to index via git add) were discovered
correctly by the staged-only merge in loadFiles(), but when loading their
diff content, FileDiff was called with staged=false (default mode).
Since these files are identical in the working tree and index, git diff
returns empty — leaving the diff pane blank.

Fix: in handleFileLoaded, when a FileAdded file has empty diff and we're
not in staged mode, retry with staged=true (git diff --cached) to get the
actual added content.

Fixes #79

* refactor: extract resolveEmptyDiff to fix gocyclo

handleFileLoaded cyclomatic complexity was 26 (threshold 20) after the
staged-only fallback addition. Extract the empty-diff resolution logic
(staged --cached retry + untracked disk read) into resolveEmptyDiff,
reducing complexity to 15.

* test: add staged-only fallback tests for resolveEmptyDiff

Three cases:
- FileAdded with empty unstaged diff retries with --cached and shows content
- --staged mode does not retry (already uses --cached)
- FileModified with empty diff does not trigger staged retry

16 of 18 new or added lines in 1 file covered. (88.89%)

5156 of 5895 relevant lines covered (87.46%)

401.28 hits per line