hyperledger / fabric-x-committer / 24199858132
91%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.295% (-0.3%) from 91.559%
24199858132

push

github

web-flow 
[utils] rename TLSMaterials to TLSCredentials, ClientMaterial to DialInfo (#527)

#### Type of change

- Improvement (improvement to code, performance, etc)
 
#### Description

The term "material" is strongly associated with "crypto material" in the
blockchain ecosystem, causing confusion. These structs hold resolved
binary
connection data (loaded certs, endpoints, retry), not raw cryptographic
artifacts.

New naming convention:
- "Config" = user-provided structure (YAML, file paths)
- "TLSCredentials" = resolved TLS data (binary cert/key/CA bytes),
  aligned with gRPC's credentials terminology
- "DialInfo" = complete connection bundle (endpoints + credentials +
retry),
  named for what consumers do with it: dial connections

#### Additional details (Optional)

Renames:
- TLSMaterials -> TLSCredentials
- ClientMaterial -> DialInfo (connection and ordererdial packages)
- NewClientCredentialsFromMaterial -> NewClientGRPCTransportCredentials
- NewServerCredentialsFromMaterial -> NewServerGRPCTransportCredentials
- NewClientTLSMaterials -> NewClientTLSCredentials
- NewServerTLSMaterials -> NewServerTLSCredentials
- NewClientMaterial -> NewDialInfo
- NewTLSMaterials -> NewTLSCredentials
- PartyIDToMaterial -> PartyIDToDialInfo
- connMaterial -> dialInfo
- material.go -> dialinfo.go (file rename)

#### Related issues

  - resolves #467

Signed-off-by: Senthilnathan <cendhu@gmail.com>

81 of 82 new or added lines in 11 files covered. (98.78%)

34 existing lines in 8 files now uncovered.

10026 of 10982 relevant lines covered (91.29%)

41934.94 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
92.36
 0.0% utils/monitoring/provider.go

Coverage Regressions

Lines Coverage ∆ File
10
59.66
 -8.4% service/sidecar/block_delivery.go
7
83.13
 -2.19% service/sidecar/sidecar.go
5
94.17
 -4.17% mock/coordinator.go
4
91.88
 -1.71% service/vc/validator_committer_service.go
3
83.98
 -0.43% service/sidecar/relay.go
2
90.77
 -0.6% mock/orderer.go
2
92.11
 0.0% service/coordinator/validator_committer_manager.go
1
94.95
 -1.01% loadgen/adapters/common.go
Jobs
ID Job ID Ran Files Coverage
1 db-test - 24199858132.1 128
84.18
 GitHub Action Run
2 unit-test - 24199858132.2 81
76.38
 GitHub Action Run
Source Files on build 24199858132