stacklok / toolhive / 24199578209

66%

Build Type

push

github

Committed by web-flow

Commit Message

Add MCPServerEntry backend discovery to VirtualMCPServer (#4698)

* Add MCPServerEntry backend discovery to VirtualMCPServer controller

VirtualMCPServer needs to discover MCPServerEntry resources (zero-infrastructure
catalog entries) and include them as backends. This enables vMCP to route traffic
to remote MCP servers declared as MCPServerEntry without proxy pods.

- Add WorkloadTypeMCPServerEntry constant and discoverer logic that lists
  MCPServerEntries by groupRef, converts them to vmcp.Backend using the remote
  URL directly from the spec (no K8s Service needed)
- Extend ConfigMap generation to include entry-type backends with remoteURL,
  transport, auth config, and CA bundle mount paths
- Mount CA bundle ConfigMaps as read-only volumes at
  /etc/toolhive/ca-bundles/<entry-name>/ when caBundleRef is configured
- Add mcpserverentries to VirtualMCPServer RBAC rules (get/list/watch)
- Add MCPServerEntry watch with optimized mapper (via MCPGroup Status.Entries)
- Add CABundlePath field to StaticBackendConfig for TLS verification
- Fix pre-existing missing mcpremoteproxies RBAC marker on controller
- Extract metadata key constants to fix goconst lint violations

Closes #4657

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate CRD manifests and API docs for CABundlePath field

Run task operator-manifests, operator-generate, and crdref-gen to
pick up the new CABundlePath field on StaticBackendConfig and the
updated RBAC markers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review feedback for MCPServerEntry discovery

- Rename metadataKeyWorkloadStat to metadataKeyWorkloadStatus (F4)
- Add nil guard to caBundleMountPath for defensive safety (F5)
- Fix volume name truncation with hash suffix to avoid collisions and
  trailing hyphens in DNS labels (F2)
- Add url.Parse validation for RemoteURL as defense-in-depth (F6)
- Propagate errors from buildCABundlePathMap and
  buildCABundleVolu... (continued)

Coverage Stats

239 of 339 new or added lines in 4 files covered. (70.5%)

37 existing lines in 5 files now uncovered.

56112 of 86302 relevant lines covered (65.02%)

62.52 hits per line