stacklok / toolhive / 24196409184

66%

Build Type

push

github

Committed by web-flow

Commit Message

Add decoupled configYAML path to MCPRegistry CRD (#4693)

* Add decoupled configYAML path to MCPRegistry CRD

The MCPRegistry CRD currently mirrors the registry server's config.yaml
structure field-by-field, coupling the operator to registry server config
changes. PR #4653 demonstrated this cost: 2,993+/2,458- lines to align
the CRD with a v2 config format.

Add a new decoupled config path alongside the existing typed fields:

- configYAML: raw YAML string passed through to the registry server as
  config.yaml, with no operator parsing or transformation
- volumes/volumeMounts: standard corev1 types for user-managed volume
  wiring (secrets, ConfigMaps, PVCs)
- pgpassSecretRef: operator-managed pgpass mount with init container
  for chmod 0600 (the one Kubernetes plumbing detail users cannot
  express through volumes alone)

The two paths are mutually exclusive (CEL + reconciler validation).
The existing typed fields are deprecated but fully functional, allowing
gradual migration. A future release will remove the legacy path.

Includes RFC document, validation with reserved name/mount path
collision detection, 27 new unit tests, and 6 example manifests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Use raw JSON for volumes/volumeMounts to reduce CRD schema size

Change Volumes and VolumeMounts fields from typed []corev1.Volume /
[]corev1.VolumeMount to []apiextensionsv1.JSON with
x-kubernetes-preserve-unknown-fields. This avoids expanding the full
Kubernetes volume OpenAPI schema into the CRD manifest, reducing the
CRD diff by ~3,900 lines.

Add ParseVolumes() and ParseVolumeMounts() helper methods on
MCPRegistrySpec that deserialize the raw JSON into typed objects at
reconciliation time. Validation of volume structure happens at pod
creation time rather than CRD admission time.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove RFC document from tracked files

The RFC is a design document used to... (continued)

Coverage Stats

203 of 389 new or added lines in 9 files covered. (52.19%)

47 existing lines in 7 files now uncovered.

55863 of 85966 relevant lines covered (64.98%)

62.53 hits per line