mindersec / minder / 24192866057

59%

push

github

fix: prevent nil pointer panic and error masking in GitHub provider check runs (#6312)

* Fix nil resp dereference and error masking in GitHub provider

Guard against nil resp before accessing resp.StatusCode in ListHooks,
StartCheckRun, and UpdateCheckRun. Without this, network-level errors
(DNS, TCP timeout, TLS) that return err with nil resp cause a nil
pointer dereference panic.

Also fix StartCheckRun error masking: non-403 errors were incorrectly
returned as ErroNoCheckPermissions, hiding the real failure cause.
Now only 403 returns the permissions error; all other errors are
returned with proper context wrapping.

Fixes #6311

* fix: drain and close resp.Body on 429 retry with gosec-compliant error handling

Include the response body leak fix from issue #6288 with proper
error handling to satisfy gosec G104 lint rule. Return values from
io.Copy and resp.Body.Close are explicitly discarded using blank
identifiers since errors from draining a rate-limit response body
are non-actionable.

7 of 8 new or added lines in 2 files covered. (87.5%)

19351 of 33017 relevant lines covered (58.61%)

36.36 hits per line