24164262159

Committed 08 Apr 2026 11:36PM UTC coverage: 85.889% (-7.0%) from 92.91%

Build # 24164262159

Build Type

Pull #23238

github

Committed by

web-flow

Commit Message

Merge 88d90acad into 5a129def6

Pull Request Pull Request #23238: TypeScript: `prettier fmt` crashes with resolve in subdirectory

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

5412 existing lines in 246 files now uncovered.

72530 of 84446 relevant lines covered (85.89%)

3.13 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.65

/src/python/pants/core/util_rules/distdir.py

# Copyright 2019 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from dataclasses import dataclass
from pathlib import Path

from pants.base.build_root import BuildRoot
from pants.engine.rules import collect_rules, rule
from pants.option.global_options import GlobalOptions
from pants.util.strutil import softwrap


def is_child_of(path: Path, directory: Path) -> bool:
    abs_path = path if path.is_absolute() else directory.joinpath(path).resolve()
    return directory == abs_path or directory in abs_path.parents


class InvalidDistDir(Exception):
    pass


@dataclass(frozen=True)
class DistDir:
    """The directory to which we write distributable files."""

    relpath: Path


@rule
async def get_distdir(global_options: GlobalOptions, buildroot: BuildRoot) -> DistDir:
    return validate_distdir(Path(global_options.pants_distdir), buildroot.pathlib_path)


def validate_distdir(distdir: Path, buildroot: Path) -> DistDir:
    if not is_child_of(distdir, buildroot):
        raise InvalidDistDir(
            softwrap(
                f"""
            When set to an absolute path, `--pants-distdir` must be relative to the build root.
            You set it to {distdir}. Instead, use a relative path or an absolute path relative
            to the build root.
            """
            )
        )
    relpath = distdir.relative_to(buildroot) if distdir.is_absolute() else distdir
    return DistDir(relpath)


def rules():
    return collect_rules()

1	# Copyright 2019 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from dataclasses import dataclass	8✔
5	from pathlib import Path	8✔
6
7	from pants.base.build_root import BuildRoot	8✔
8	from pants.engine.rules import collect_rules, rule	8✔
9	from pants.option.global_options import GlobalOptions	8✔
10	from pants.util.strutil import softwrap	8✔
11
12
13	def is_child_of(path: Path, directory: Path) -> bool:	8✔
14	abs_path = path if path.is_absolute() else directory.joinpath(path).resolve()	2✔
15	return directory == abs_path or directory in abs_path.parents	2✔
16
17
18	class InvalidDistDir(Exception):	8✔
19	pass	8✔
20
21
22	@dataclass(frozen=True)	8✔
23	class DistDir:	8✔
24	"""The directory to which we write distributable files."""
25
26	relpath: Path
27
28
29	@rule	8✔
30	async def get_distdir(global_options: GlobalOptions, buildroot: BuildRoot) -> DistDir:	8✔
31	return validate_distdir(Path(global_options.pants_distdir), buildroot.pathlib_path)	2✔
32
33
34	def validate_distdir(distdir: Path, buildroot: Path) -> DistDir:	8✔
35	if not is_child_of(distdir, buildroot):	2✔
UNCOV 36	raise InvalidDistDir(	×
37	softwrap(
38	f"""
39	When set to an absolute path, `--pants-distdir` must be relative to the build root.
40	You set it to {distdir}. Instead, use a relative path or an absolute path relative
41	to the build root.
42	"""
43	)
44	)
45	relpath = distdir.relative_to(buildroot) if distdir.is_absolute() else distdir	2✔
46	return DistDir(relpath)	2✔
47
48
49	def rules():	8✔
50	return collect_rules()	8✔

pantsbuild / pants / 24164262159

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous