stacklok / toolhive / 24182551495

65%

Build Type

push

github

Committed by web-flow

Commit Message

Add MCPServerEntry validation controller and MCPGroup integration (#4664)

* Add MCPServerEntry validation controller and MCPGroup integration

Introduce a validation-only controller for MCPServerEntry that checks
referenced resources (MCPGroup, MCPExternalAuthConfig, CA bundle
ConfigMap) exist and sets status conditions accordingly. The controller
never creates infrastructure or probes remote URLs.

Integrate MCPServerEntry into the MCPGroup controller so groups track
entry membership in Entries/EntryCount status fields, handle entry
deletion notifications, and watch for entry changes.

Wire up field indexing for MCPServerEntry.Spec.GroupRef and register
the controller in the operator's server controller setup. Extract
field indexer setup into setupGroupRefFieldIndexes to keep
setupServerControllers under the cyclomatic complexity limit.

Refs: #4656

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add MCPServerEntry to Chainsaw RBAC assertions and integration test suites

The Chainsaw E2E tests assert on the exact ClusterRole contents, and
the integration test suites need field indexers for all types that
reference MCPGroup via spec.groupRef.

Add mcpserverentries and mcpserverentries/status to the RBAC golden
files for both multi-tenancy and single-tenancy Chainsaw test setups.
Register MCPServerEntry field indexer in all five integration test
suite BeforeSuite blocks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review feedback for MCPServerEntry controller

- Fix RBAC: reduce mcpserverentries verbs to get;list;watch (validation-only)
- Fix field indexer nesting bug in 4 integration test suites where
  MCPServerEntry indexer was unreachable on the happy path
- Add MCPGroup Ready phase check in validateGroupRef, matching
  MCPServer/MCPRemoteProxy behavior
- Return transient errors for requeue instead of persisting misleading
  NotFound conditions; sanitize error messages in status conditi... (continued)

Coverage Stats

269 of 510 new or added lines in 5 files covered. (52.75%)

6 existing lines in 3 files now uncovered.

55556 of 85524 relevant lines covered (64.96%)

62.51 hits per line