mroderick / codebar-planner / 24180026696

96%

master: 95%

push

github

fix: handle duplicate InvitationLogEntry creation on retry

When re-sending workshop invitations, the InvitationLogger would attempt to
create a new InvitationLogEntry for members with existing invitations,
causing a uniqueness validation error: 'Member has already been taken'.

This fix uses Rails' idiomatic find_or_initialize_by pattern to check if
an entry already exists before creating a new one. If the entry exists
(meaning the member was already processed), it returns the existing entry
without incrementing the counter.

Root cause:
- InvitationLogEntry validates uniqueness on (member_id, invitation_type,
  invitation_id)
- Re-sending invitations to the same workshop would try to log success
  for an already-logged member+invitation combination
- This caused batch jobs to fail mid-process with validation errors

Affected scenarios:
- Re-sending invitations for the same workshop
- Sending invitations with audience='everyone' (processes both students and
  coaches, where a member might be in both groups)
- Retrying failed invitation batches

Fix:
- Replace create! with find_or_initialize_by in log_success, log_failure,
  and log_skipped methods
- Return existing entry if already persisted
- Only increment counter when creating a new entry
- Extract shared helper methods for cleaner code

Tests:
- Add retry tests for all three logging methods to verify no duplicate
  entries are created on repeated calls with the same member+invitation

19 of 19 new or added lines in 1 file covered. (100.0%)

3478 of 3641 relevant lines covered (95.52%)

46.0 hits per line