stripe / smokescreen / 24180064184

56%

Build Type

push

github

Committed by web-flow

Commit Message

acl: pass *http.Request through Decide via DecideArgs (#286)

* acl: replace Decide(service, host, proxy) with Decide(DecideArgs)

Replace the three positional string arguments on the Decider interface with
a DecideArgs struct. This keeps the interface stable as new fields are
added — the immediate motivation is passing *http.Request so custom Decider
implementations (e.g. request-aware authorization layers) can inspect request
headers without requiring a separate interface method.

ACL.Decide itself does not inspect Req; the field is documented as existing
solely for custom implementations. Tests are updated to use the new struct
form and two previously missing proxy-host cases are added (allowed proxy +
disallowed target, wildcard proxy glob), along with a test asserting that
ACL.Decide produces identical results regardless of the Req value.

Committed-By-Agent: claude

* smokescreen: remove TestHostSquareBrackets

Go 1.21 tightened URL validation in both the HTTP client (url.Parse) and
the HTTP server (request-line parsing), causing both layers to reject
hostnames containing square brackets before the request reaches
smokescreen's handler. The test can no longer exercise smokescreen's own
host-validation logic for these inputs and is removed.

Committed-By-Agent: claude

---------

Co-authored-by: Harold Simpson <harold@stripe.com>

Coverage Stats

14 of 15 new or added lines in 2 files covered. (93.33%)

9 existing lines in 1 file now uncovered.

1812 of 3224 relevant lines covered (56.2%)

46.51 hits per line