safe-global / safe-client-gateway / 24174068770

90%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(circuit-breaker): simplify configuration and remove per-circuit overrides (#2997)

* refactor(circuit-breaker): simplify configuration and remove per-circuit overrides

Unify failureThreshold/successThreshold into a single threshold value,
replace halfOpenMaxRequests with percentage-based halfOpenFailureRateThreshold,
remove per-circuit config overrides, and clean up unused metrics (successCount,
halfOpenRequestCounts). recordFailure now accepts circuit name instead of object.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* style: fix prettier formatting

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(circuit-breaker): lower default threshold and improve error handling

Move canProceedOrFail outside try block, record success for non-server
errors, and reduce default threshold from 20 to 10.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* test(circuit-breaker): fix integration test to use dynamic threshold

The test hardcoded 2 failures to trip the circuit, but the default
threshold was lowered to 10. Use defaultThreshold in a loop to match
the pattern of other circuit breaker tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(circuit-breaker): address review feedback on HALF_OPEN state and config

- Reset lastFailureTime on HALF_OPEN transition to prevent stale value
  from causing confusing discardOldFailures behavior
- Fix .env.sample.json CIRCUIT_BREAKER_THRESHOLD default (20 -> 10) to
  match configuration.ts
- Add dedicated unit tests for canProceedOrFail public method

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(circuit-breaker): address review feedback on HALF_OPEN state and config

- Skip discardOldFailures in HALF_OPEN state to prevent stale
  lastFailureTime from resetting failureCount
- Fix .env.sample.json CIRCUIT_BREAKER_THRESHOLD default (20 -> 10) to
  match configuration.ts
- Add ... (continued)

Coverage Stats

3236 of 4022 branches covered (80.46%)

Branch coverage included in aggregate %.

48 of 49 new or added lines in 2 files covered. (97.96%)

3 existing lines in 3 files now uncovered.

15227 of 16469 relevant lines covered (92.46%)

610.4 hits per line