stacklok / toolhive / 24162994031

65%

Build Type

push

github

Committed by web-flow

Commit Message

Issues/4681 - Recognize ErrAbortHandler in recovery middleware (#4682)

* Issues/4681 - Recognize ErrAbortHandler in recovery middleware

ReverseProxy ends streaming responses with panic(http.ErrAbortHandler).
Pointer equality on recover() missed some values that still print as
net/http: abort Handler, which produced false ERROR logs, Sentry noise,
and http.Error after headers were sent for SSE streams.

Detect abort with errors.Is and a same-message fallback, then re-panic
the sentinel. Add tests for wrapped and duplicate-error cases.

* Issues/4681 - Refine recovery ErrAbortHandler per MR review

Remove the Error()-string fallback; consensus was that it could
false-positive and we have no proven path where only that branch
matched. Keep pointer identity and errors.Is for wrapped aborts.

Consolidate ErrAbortHandler re-panic tests into one table-driven test.
Move isErrAbortHandler below exported API per go-style ordering.

---------

Co-authored-by: Mauricio Bonetti <mbonetti@contractor.indeed.com>

Coverage Stats

11 of 13 new or added lines in 1 file covered. (84.62%)

5 existing lines in 1 file now uncovered.

55050 of 84738 relevant lines covered (64.96%)

62.92 hits per line