• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 24162994031
65%

Build:
DEFAULT BRANCH: main
Ran 08 Apr 2026 11:03PM UTC
Jobs 1
Files 608
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Apr 2026 10:57PM UTC coverage: 64.965% (+0.02%) from 64.942%
24162994031

push

github

web-flow
Issues/4681 - Recognize ErrAbortHandler in recovery middleware (#4682)

* Issues/4681 - Recognize ErrAbortHandler in recovery middleware

ReverseProxy ends streaming responses with panic(http.ErrAbortHandler).
Pointer equality on recover() missed some values that still print as
net/http: abort Handler, which produced false ERROR logs, Sentry noise,
and http.Error after headers were sent for SSE streams.

Detect abort with errors.Is and a same-message fallback, then re-panic
the sentinel. Add tests for wrapped and duplicate-error cases.

* Issues/4681 - Refine recovery ErrAbortHandler per MR review

Remove the Error()-string fallback; consensus was that it could
false-positive and we have no proven path where only that branch
matched. Keep pointer identity and errors.Is for wrapped aborts.

Consolidate ErrAbortHandler re-panic tests into one table-driven test.
Move isErrAbortHandler below exported API per go-style ordering.

---------

Co-authored-by: Mauricio Bonetti <mbonetti@contractor.indeed.com>

11 of 13 new or added lines in 1 file covered. (84.62%)

5 existing lines in 1 file now uncovered.

55050 of 84738 relevant lines covered (64.96%)

62.92 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
87.5
-1.39% pkg/recovery/recovery.go

Coverage Regressions

Lines Coverage ∆ File
5
82.81
0.0% pkg/vmcp/composer/workflow_engine.go
Jobs
ID Job ID Ran Files Coverage
1 24162994031.1 08 Apr 2026 11:03PM UTC 608
64.96
GitHub Action Run
Source Files on build 24162994031
  • Tree
  • List 608
  • Changed 7
  • Source Changed 1
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #24162994031
  • ce31e57b on github
  • Prev Build on main (#24162773446)
  • Next Build on main (#24163034031)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc