dcdpr / jp / 24159695622

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(workspace): Prevent premature session-mapping deletion (#524)

Introduce a `Liveness` enum (`Alive`, `Dead`, `Unknown`) to replace the
previous boolean return from session-process checks. This allows the
cleanup logic to distinguish three states instead of collapsing `Alive`
and `Unknown` into a single `false`.

The old logic treated `Getsid`/`Hwnd` sessions and `Env` sessions the
same way when process liveness was inconclusive: it would fall through
to a conversation-existence check against the *in-memory* workspace
index. This had two bugs. First, a `Getsid`/`Hwnd` session whose process
is still alive could be deleted if its conversations hadn't yet been
indexed by the current process. Second, the in-memory index is a
snapshot taken at startup, so any conversation created by a concurrent
`jp` process after that point was invisible, making that session look
orphaned.

The new rules are:

- **Getsid/Hwnd** — if the process is alive, the session survives
unconditionally. Only delete when the process is confirmed dead.
- **Env** — liveness is unknowable; fall back to a conversation-
existence check, but now re-scan conversation IDs from disk rather than
relying on the stale in-memory index.

The `is_session_process_dead` helper is renamed to
`is_session_process_liveness`, and `is_pid_dead`/`is_hwnd_dead` become
`pid_liveness`/`hwnd_liveness` to reflect that they now return a
`Liveness` value rather than a boolean.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

22 of 30 new or added lines in 1 file covered. (73.33%)

1 existing line in 1 file now uncovered.

20165 of 31314 relevant lines covered (64.4%)

349.46 hits per line