Alan-Jowett / sonde / 24152690355

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: centralize workspace version to 0.4.0 and add `firmware_version` to WAKE (#690)

* feat: centralize workspace version to 0.4.0 and add irmware_version to WAKE

Centralize version management across the sonde workspace:

- Add [workspace.package] version = "

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* style: apply rustfmt formatting

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR review feedback

- Modem: use CARGO_PKG_VERSION_{MAJOR,MINOR,PATCH} env vars instead of
  manually parsing CARGO_PKG_VERSION. Adds explicit range checks and
  handles pre-release suffixes safely.
- Registry: take firmware_version: String by value in update_telemetry
  to avoid redundant allocation on the WAKE hot path.
- State bundle: persist firmware_version through export/import round-trips
  via new CBOR key NODE_KEY_FW_VERSION (14). Optional for backward compat.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: validate firmware_version length and ASCII on decode

Add length cap (32 bytes) and ASCII-only check to get_string() in the
protocol message decoder. Prevents unbounded allocation from malicious
or buggy peers sending oversized CBOR text values for firmware_version.

Add tests for oversized and non-ASCII firmware_version rejection.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address second round of PR review feedback

- protocol.md: document exact wire constraints for firmware_version
  (ASCII-only, max 32 bytes) instead of saying "semantic version".
- protocol.md: reword evolution rules to explicitly allow pre-1.0
  breaking changes, resolving inconsistency with the additive-only rule.
- engine.rs: move firmware_version into update_telemetry instead of
  cloning, read back from updated_node for the event payload.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.... (continued)

Coverage Stats

58 of 87 new or added lines in 7 files covered. (66.67%)

2 existing lines in 2 files now uncovered.

21274 of 26069 relevant lines covered (81.61%)

140.72 hits per line