24150058251
65%

Ran 08 Apr 2026 05:53PM UTC

Jobs 1

Files 610

Run time 1min

Badge

Embed ▾

Committed 08 Apr 2026 05:48PM UTC coverage: 65.107% (+0.03%) from 65.08%

Build # 24150058251

Build Type

push

github

Committed by

web-flow

Commit Message

Update Redis ACL examples for auth server (#4675)

The Redis ACL examples in the repo were missing commands that the auth server actually uses, which would cause runtime permission errors for upstream token storage and user creation flows. This audits `pkg/authserver/storage/redis.go` against the documented ACL entries and adds the missing commands.

## Changes

| File | What changed |
|------|-------------|
| `examples/operator/redis-storage/sentinel-service.yaml` | Added `+PEXPIRE +PTTL +MGET` to the example ACL entry |
| `docs/redis-storage.md` | Added `+SETNX +PEXPIRE +PTTL +MGET +EVALSHA` to the ACL example and updated the security note prose to list all required commands |

## Missing commands and why they're needed

| Command | Used by |
|---------|---------|
| `SETNX` | `CreateUser`, `CreateProviderIdentity` — atomic check-and-set for uniqueness |
| `PEXPIRE` | `storeUpstreamTokensScript` Lua script — millisecond-precision TTL on index sets |
| `PTTL` | `storeUpstreamTokensScript` Lua script — checks remaining TTL before extending |
| `MGET` | `GetAllUpstreamTokens` — batch fetch of all provider tokens for a session |
| `EVALSHA` | All Lua scripts after first execution — Redis caches the script and runs by SHA |

Coverage Stats

54997 of 84472 relevant lines covered (65.11%)

62.63 hits per line

Coverage Regressions

Lines	Coverage	∆	File
9	22.99	-0.57%	pkg/client/manager.go
3	71.85	-1.11%	pkg/ignore/processor.go
3	70.0	-3.33%	pkg/state/local.go
2	61.97	-1.41%	pkg/networking/port.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	24150058251.1	08 Apr 2026 05:53PM UTC	610	65.11	GitHub Action Run

stacklok / toolhive / 24150058251
65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24150058251

stacklok / toolhive / 24150058251 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24150058251

stacklok / toolhive / 24150058251
65%

README BADGES
x