optimizely / go-sdk / 24145719844

92%

push

github

[AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing (#443)

* [AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing

* Fix Feature Rollout injection not updating feature.FeatureExperiments

The injectFeatureRolloutVariations function was modifying experiments in
experimentIDMap but not updating the copies in feature.FeatureExperiments.
This caused the decision service to use experiments without the injected
"everyone else" variation, leading to incorrect bucketing and fallthrough
to rollout rules instead of returning the FR experiment decision.

When MapFeatures runs, it creates feature.FeatureExperiments by copying
experiments from experimentIDMap. Since Go copies struct values, later
modifications to experimentIDMap experiments (like appending to
TrafficAllocation slice) don't affect the copies in FeatureExperiments.

The fix updates both experimentIDMap AND feature.FeatureExperiments to
ensure the decision service sees the complete injected variations.

This fixes FSC test failures where users were getting rule_key from
rollout rules (e.g., "ee_rule_1002") instead of from FR experiments
(e.g., "fr_zero_exp").

* Add test to verify injection updates both experimentIDMap and FeatureExperiments

This test ensures that the Feature Rollout injection properly updates
both the experimentIDMap and the feature's FeatureExperiments slice,
preventing regression of the bug where only experimentIDMap was updated.

---------

Co-authored-by: Matjaz Pirnovar <Mat001@users.noreply.github.com>

11 of 11 new or added lines in 1 file covered. (100.0%)

5699 of 6202 relevant lines covered (91.89%)

6967.01 hits per line