FlexMeasures / flexmeasures / 24140823461

81%

push

github

Add "Create forecast" button to sensor page (#1985)

* Initial plan

* agents/ui-specialist: introduce new agent from PR #1985 lessons

Context:
- PR #1985 added the 'Create Forecast' button to the sensor page UI
- No agent existed to encode Flask/Jinja2/JS UI patterns for FlexMeasures
- Patterns were worked out from scratch during the session

Change:
- Created .github/agents/ui-specialist.md covering:
  - Side-panel pattern (sidepanel-container / left-sidepanel-label hierarchy)
  - Permission-gating idiom: always short-circuit DB calls behind permission check
  - JS fetch → poll loop → Toast → reload pattern with correct status-code handling
  - Toast/spinner setup and teardown discipline
  - Disabled-button vs. hidden-panel distinction
  - Marshmallow data_key awareness for JS POST payloads
  - UI test checklist (access, permissions, data availability, boundary, not-called guard)
  - Known architectural debt (absent CSRF, session-expiry in poll loop, type hint gap)

* agents/coordinator: register UI Specialist; encode UI dev patterns

Context:
- PR #1985 established concrete UI patterns (side panel, JS poll loop,
  permission-gated view logic) that the agent system had no coverage for
- A new UI Specialist agent was created to own those patterns
- Coordinator roster and domain knowledge should reflect this

Change:
- Added UI Specialist to the agent roster (item 9)
- Added 'UI Development Patterns' subsection to Domain Knowledge with:
  - Jinja2 side-panel template snippet
  - Python view short-circuit data-guard pattern
  - JS fetch/poll/Toast/reload skeleton
  - Agent responsibility table for UI-touching PRs

* style: black

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: set result_ttl for wrap_up_job

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: detached data source in case of forecasting job

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: `HANDLING RQ FORECASTING EXCEPTION: <class 'TypeError'>: Job.__init__() mis... (continued)

34 of 37 new or added lines in 5 files covered. (91.89%)

11720 of 15051 relevant lines covered (77.87%)

0.78 hits per line