dunglas / mercure / 24129134708

84%

master: 93%

push

github

fix(bolt): race in dispatchHistory when RequestLastEventID is not found (#1199)

In BoltTransport.dispatchHistory, the toSeq bound (captured at subscriber
registration time) was only checked in the history-replay branch, not in
the ID-search branch. If a new update was persisted between the subscriber
being added to the list and dispatchHistory reading the DB, the loop would
iterate past toSeq into the new entry, setting responseLastEventID to the
wrong value. This caused TestUnknownLastEventID to flake.

5 of 5 new or added lines in 1 file covered. (100.0%)

1754 of 2082 relevant lines covered (84.25%)

69.28 hits per line