dcdpr / jp / 24127426485

67%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(config): Better typed mergeable fields in `jp_config` (#520)

`AssistantConfig.system_prompt`, `system_prompt_sections`, and
`instructions` were previously typed as `MergeableString` and
`MergeableVec<T>` — wrapper types carrying merge-strategy metadata
through schematic's partial layer. These leaked into every callsite,
requiring `.to_vec()` on sections and `.map(String::from)` on the system
prompt.

The fields are now plain `String` and `Vec<T>`, with
`#[setting(partial_via = ...)]` keeping the merge behavior in the
partial layer. A new `vec_to_mergeable_partial` helper converts `Vec<T>`
back to `MergeableVec<T::Partial>` for `ToPartial` impls.

Alongside this, `AppConfig::from_partial_with_defaults` is introduced to
centralize the application of `#[setting(default)]` values. Schematic's
`Config::from_partial` does not inject defaults on its own — previously
`build()` merged default values manually before calling `from_partial`.
That logic is now encapsulated in `from_partial_with_defaults`, which
both `build()` and `new_test()` delegate to.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

25 of 26 new or added lines in 6 files covered. (96.15%)

13 existing lines in 3 files now uncovered.

20060 of 31194 relevant lines covered (64.31%)

215.5 hits per line