• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

dcdpr / jp / 24127426485
67%

Build:
DEFAULT BRANCH: main
Ran 08 Apr 2026 09:13AM UTC
Jobs 1
Files 257
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Apr 2026 09:08AM UTC coverage: 64.307% (+0.2%) from 64.127%
24127426485

push

github

web-flow
refactor(config): Better typed mergeable fields in `jp_config` (#520)

`AssistantConfig.system_prompt`, `system_prompt_sections`, and
`instructions` were previously typed as `MergeableString` and
`MergeableVec<T>` — wrapper types carrying merge-strategy metadata
through schematic's partial layer. These leaked into every callsite,
requiring `.to_vec()` on sections and `.map(String::from)` on the system
prompt.

The fields are now plain `String` and `Vec<T>`, with
`#[setting(partial_via = ...)]` keeping the merge behavior in the
partial layer. A new `vec_to_mergeable_partial` helper converts `Vec<T>`
back to `MergeableVec<T::Partial>` for `ToPartial` impls.

Alongside this, `AppConfig::from_partial_with_defaults` is introduced to
centralize the application of `#[setting(default)]` values. Schematic's
`Config::from_partial` does not inject defaults on its own — previously
`build()` merged default values manually before calling `from_partial`.
That logic is now encapsulated in `from_partial_with_defaults`, which
both `build()` and `new_test()` delegate to.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

25 of 26 new or added lines in 6 files covered. (96.15%)

13 existing lines in 3 files now uncovered.

20060 of 31194 relevant lines covered (64.31%)

215.5 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
82.86
0.22% crates/jp_config/src/lib.rs

Coverage Regressions

Lines Coverage ∆ File
11
59.57
-4.79% crates/jp_config/src/types/vec.rs
1
81.64
-0.25% crates/jp_cli/src/cmd/query/tool/renderer.rs
1
68.08
-0.21% crates/jp_cli/src/cmd/query/turn_loop.rs
Jobs
ID Job ID Ran Files Coverage
1 24127426485.1 08 Apr 2026 09:13AM UTC 257
64.31
GitHub Action Run
Source Files on build 24127426485
  • Tree
  • List 257
  • Changed 16
  • Source Changed 7
  • Coverage Changed 16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #24127426485
  • 9ea8e05a on github
  • Prev Build on main (#24075380725)
  • Next Build on main (#24158681988)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc