stacklok / toolhive / 24126081599

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix(telemetry): warn instead of crashing when OTLP endpoint has no enabled exporters (#4648)

* fix(telemetry): warn instead of crashing when OTLP endpoint has no enabled exporters

When an OTLP endpoint is configured via `thv config otel set-endpoint`
but both tracing and metrics are disabled, `thv serve` crashes with a
fatal validation error preventing the server from starting.

Instead of failing, log a warning and clear the endpoint so the server
starts normally. This avoids a confusing "Health check failed" error
in ToolHive Studio.

Fixes #4647

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(telemetry): extract handleUnusedEndpoint to reduce cyclomatic complexity

Move the unused endpoint check into a dedicated helper function to
keep NewServeProvider under the gocyclo threshold (15).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(telemetry): enable tracing by default when OTLP endpoint has no enabled exporters

Instead of clearing the endpoint (which would silently drop telemetry
for users who configured an endpoint expecting it to work), enable
tracing by default so the endpoint is actually used.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 15 new or added lines in 1 file covered. (0.0%)

38 existing lines in 5 files now uncovered.

54845 of 84189 relevant lines covered (65.15%)

63.56 hits per line