GrottoCenter / grottocenter-api / 24110038352

87%

push

github

fix(search): return 400 instead of 500 for unknown entity names

SearchService.fieldSearch and collectionSearch return null for
unrecognized entity names (e.g. 'cave' instead of 'caves').
The field-search and advanced-search controllers accessed properties
on the null result without a guard, causing a TypeError crash.

Add null checks after the search calls that return a 400 Bad Request
listing the valid entity names.

2839 of 3442 branches covered (82.48%)

Branch coverage included in aggregate %.

3 of 8 new or added lines in 2 files covered. (37.5%)

5899 of 6705 relevant lines covered (87.98%)

94.39 hits per line