24103090537

Committed 07 Apr 2026 08:33PM UTC coverage: 21.044%. Remained the same

Build # 24103090537

Build Type

Pull #905

github

Committed by

web-flow

Commit Message

Merge aa8c04d8e into 0969584cc

Pull Request Pull Request #905: fix: code quality improvements in pass.cpp

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

26 existing lines in 1 file now uncovered.

1109 of 5270 relevant lines covered (21.04%)

7.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

45.54

/src/pass.cpp

// SPDX-FileCopyrightText: 2016 Anne Jan Brouwer
// SPDX-License-Identifier: GPL-3.0-or-later
#include "pass.h"
#include "gpgkeystate.h"
#include "helpers.h"
#include "qtpasssettings.h"
#include "util.h"
#include <QDir>
#include <QFileInfo>
#include <QProcess>
#include <QRandomGenerator>
#include <QRegularExpression>
#include <utility>

#ifdef QT_DEBUG
#include "debughelper.h"
#endif

using Enums::GIT_INIT;
using Enums::GIT_PULL;
using Enums::GIT_PUSH;
using Enums::GPG_GENKEYS;
using Enums::PASS_COPY;
using Enums::PASS_INIT;
using Enums::PASS_INSERT;
using Enums::PASS_MOVE;
using Enums::PASS_OTP_GENERATE;
using Enums::PASS_REMOVE;
using Enums::PASS_SHOW;

/**
 * @brief Pass::Pass wrapper for using either pass or the pass imitation
 */
Pass::Pass() : wrapperRunning(false), env(QProcess::systemEnvironment()) {
  connect(&exec,
          static_cast<void (Executor::*)(int, int, const QString &,
                                         const QString &)>(&Executor::finished),
          this, &Pass::finished);

  // This was previously using direct QProcess signals.
  // The code now uses Executor instead of raw QProcess for better control.
  // connect(&process, SIGNAL(error(QProcess::ProcessError)), this,
  //        SIGNAL(error(QProcess::ProcessError)));

  connect(&exec, &Executor::starting, this, &Pass::startingExecuteWrapper);
  env.append("WSLENV=PASSWORD_STORE_DIR/p");
}

/**
 * @brief Executes a wrapper command.
 * @param id Process ID
 * @param app Application to execute
 * @param args Arguments
 * @param readStdout Whether to read stdout
 * @param readStderr Whether to read stderr
 */
void Pass::executeWrapper(PROCESS id, const QString &app,
                          const QStringList &args, bool readStdout,
                          bool readStderr) {
  executeWrapper(id, app, args, QString(), readStdout, readStderr);
}

void Pass::executeWrapper(PROCESS id, const QString &app,
                          const QStringList &args, QString input,
                          bool readStdout, bool readStderr) {
#ifdef QT_DEBUG
  dbg() << app << args;
#endif
  exec.execute(id, QtPassSettings::getPassStore(), app, args, std::move(input),
               readStdout, readStderr);
}

/**
 * @brief Initializes the pass wrapper environment.
 */
void Pass::init() {
#ifdef __APPLE__
  // If it exists, add the gpgtools to PATH
  if (QFile("/usr/local/MacGPG2/bin").exists())
    env.replaceInStrings("PATH=", "PATH=/usr/local/MacGPG2/bin:");
  // Add missing /usr/local/bin
  if (env.filter("/usr/local/bin").isEmpty())
    env.replaceInStrings("PATH=", "PATH=/usr/local/bin:");
#endif

  if (!QtPassSettings::getGpgHome().isEmpty()) {
    QDir absHome(QtPassSettings::getGpgHome());
    absHome.makeAbsolute();
    env << "GNUPGHOME=" + absHome.path();
  }
}

/**
 * @brief Pass::Generate use either pwgen or internal password
 * generator
 * @param length of the desired password
 * @param charset to use for generation
 * @return the password
 */
auto Pass::generatePassword(unsigned int length, const QString &charset)
    -> QString {
  QString passwd;
  if (QtPassSettings::isUsePwgen()) {
    // --secure goes first as it overrides --no-* otherwise
    QStringList args;
    args.append("-1");
    if (!QtPassSettings::isLessRandom()) {
      args.append("--secure");
    }
    args.append(QtPassSettings::isAvoidCapitals() ? "--no-capitalize"
                                                  : "--capitalize");
    args.append(QtPassSettings::isAvoidNumbers() ? "--no-numerals"
                                                 : "--numerals");
    if (QtPassSettings::isUseSymbols()) {
      args.append("--symbols");
    }
    args.append(QString::number(length));
    // executeBlocking returns 0 on success, non-zero on failure
    if (Executor::executeBlocking(QtPassSettings::getPwgenExecutable(), args,
                                  &passwd) == 0) {
      static const QRegularExpression literalNewLines{"[\\n\\r]"};
      passwd.remove(literalNewLines);
    } else {
      passwd.clear();
#ifdef QT_DEBUG
      qDebug() << __FILE__ << ":" << __LINE__ << "\t"
               << "pwgen fail";
#endif
      // Error is already handled by clearing passwd; no need for critical
      // signal here
    }
  } else {
    // Validate charset - if CUSTOM is selected but chars are empty,
    // fall back to ALLCHARS to prevent weak passwords (issue #780)
    QString effectiveCharset = charset;
    if (effectiveCharset.isEmpty()) {
      effectiveCharset = QtPassSettings::getPasswordConfiguration()
                             .Characters[PasswordConfiguration::ALLCHARS];
    }
    if (effectiveCharset.length() > 0) {
      passwd = generateRandomPassword(effectiveCharset, length);
    } else {
      emit critical(
          tr("No characters chosen"),
          tr("Can't generate password, there are no characters to choose from "
             "set in the configuration!"));
    }
  }
  return passwd;
}

/**
 * @brief Pass::gpgSupportsEd25519 check if GPG supports ed25519 (ECC)
 * GPG 2.1+ supports ed25519 which is much faster for key generation
 * @return true if ed25519 is supported
 */
bool Pass::gpgSupportsEd25519() {
  QString out, err;
  if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(),
                                {"--version"}, &out, &err) != 0) {
    return false;
  }
  QRegularExpression versionRegex(R"(gpg \(GnuPG\) (\d+)\.(\d+))");
  QRegularExpressionMatch match = versionRegex.match(out);
  if (!match.hasMatch()) {
    return false;
  }
  int major = match.captured(1).toInt();
  int minor = match.captured(2).toInt();
  return major > 2 || (major == 2 && minor >= 1);
}

/**
 * @brief Pass::getDefaultKeyTemplate return default key generation template
 * Uses ed25519 if supported, otherwise falls back to RSA
 * @return GPG batch template string
 */
QString Pass::getDefaultKeyTemplate() {
  if (gpgSupportsEd25519()) {
    return QStringLiteral("%echo Generating a default key\n"
                          "Key-Type: EdDSA\n"
                          "Key-Curve: Ed25519\n"
                          "Subkey-Type: ECDH\n"
                          "Subkey-Curve: Curve25519\n"
                          "Name-Real: \n"
                          "Name-Comment: QtPass\n"
                          "Name-Email: \n"
                          "Expire-Date: 0\n"
                          "%no-protection\n"
                          "%commit\n"
                          "%echo done");
  }
  return QStringLiteral("%echo Generating a default key\n"
                        "Key-Type: RSA\n"
                        "Subkey-Type: RSA\n"
                        "Name-Real: \n"
                        "Name-Comment: QtPass\n"
                        "Name-Email: \n"
                        "Expire-Date: 0\n"
                        "%no-protection\n"
                        "%commit\n"
                        "%echo done");
}

namespace {
auto resolveWslGpgconfPath(const QString &lastPart) -> QString {
  int lastSep = lastPart.lastIndexOf('/');
  if (lastSep < 0) {
    lastSep = lastPart.lastIndexOf('\\');
  }
  if (lastSep >= 0) {
    return lastPart.left(lastSep + 1) + "gpgconf";
  }
  return QStringLiteral("gpgconf");
}

QString findGpgconfInGpgDir(const QString &gpgPath) {
  QFileInfo gpgInfo(gpgPath);
  if (!gpgInfo.isAbsolute()) {
    return QString();
  }

  QDir dir(gpgInfo.absolutePath());

#ifdef Q_OS_WIN
  QFileInfo candidateExe(dir.filePath("gpgconf.exe"));
  if (candidateExe.isExecutable()) {
    return candidateExe.filePath();
  }
#endif

  QFileInfo candidate(dir.filePath("gpgconf"));
  if (candidate.isExecutable()) {
    return candidate.filePath();
  }
  return QString();
}
} // namespace

auto Pass::resolveGpgconfCommand(const QString &gpgPath)
    -> ResolvedGpgconfCommand {
  if (gpgPath.trimmed().isEmpty()) {
    return {"gpgconf", {}};
  }

#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
  QStringList parts = QProcess::splitCommand(gpgPath);
#else
  QStringList splitCommandCompat(const QString &command) {
    QStringList result;
    QString current;
    bool inSingleQuote = false;
    bool inDoubleQuote = false;
    bool escaping = false;
    for (QChar ch : command) {
      if (escaping) {
        current.append(ch);
        escaping = false;
        continue;
      }
      if (ch == '\\') {
        escaping = true;
        continue;
      }
      if (ch == '\'' && !inDoubleQuote) {
        inSingleQuote = !inSingleQuote;
        continue;
      }
      if (ch == '"' && !inSingleQuote) {
        inDoubleQuote = !inDoubleQuote;
        continue;
      }
      if (ch.isSpace() && !inSingleQuote && !inDoubleQuote) {
        if (!current.isEmpty()) {
          result.append(current);
          current.clear();
        }
        continue;
      }
      current.append(ch);
    }
    if (escaping) {
      current.append('\\');
    }
    if (!current.isEmpty()) {
      result.append(current);
    }
    return result;
  }
  QStringList parts = splitCommandCompat(gpgPath);
#endif

  if (parts.isEmpty()) {
    return {"gpgconf", {}};
  }

  const QString first = parts.first();
  if (first == "wsl" || first == "wsl.exe") {
    if (parts.size() >= 2 && parts.at(1).startsWith("sh")) {
      return {"gpgconf", {}};
    }
    if (parts.size() >= 2 &&
        QFileInfo(parts.last()).fileName().startsWith("gpg")) {
      QString wslGpgconf = resolveWslGpgconfPath(parts.last());
      parts.removeLast();
      parts.append(wslGpgconf);
      return {parts.first(), parts.mid(1)};
    }
    return {"gpgconf", {}};
  }

  if (!first.contains('/') && !first.contains('\\')) {
    return {"gpgconf", {}};
  }

  QString gpgconfPath = findGpgconfInGpgDir(gpgPath);
  if (!gpgconfPath.isEmpty()) {
    return {gpgconfPath, {}};
  }

  return {"gpgconf", {}};
}

/**
 * @brief Pass::GenerateGPGKeys internal gpg keypair generator . .
 * @param batch GnuPG style configuration string
 */
void Pass::GenerateGPGKeys(QString batch) {
  // Kill any stale GPG agents that might be holding locks on the key database
  // This helps avoid "database locked" timeouts during key generation
  QString gpgPath = QtPassSettings::getGpgExecutable();
  if (!gpgPath.isEmpty()) {
    ResolvedGpgconfCommand gpgconf = resolveGpgconfCommand(gpgPath);
    QStringList killArgs = gpgconf.arguments;
    killArgs << "--kill";
    killArgs << "gpg-agent";
    // Use same environment as key generation to target correct gpg-agent
    Executor::executeBlocking(env, gpgconf.program, killArgs);
  }

  executeWrapper(GPG_GENKEYS, gpgPath, {"--gen-key", "--no-tty", "--batch"},
                 std::move(batch));
}

/**
 * @brief Pass::listKeys list users
 * @param keystrings
 * @param secret list private keys
 * @return QList<UserInfo> users
 */
auto Pass::listKeys(QStringList keystrings, bool secret) -> QList<UserInfo> {
  QStringList args = {"--no-tty", "--with-colons", "--with-fingerprint"};
  args.append(secret ? "--list-secret-keys" : "--list-keys");

  for (const QString &keystring : AS_CONST(keystrings)) {
    if (!keystring.isEmpty()) {
      args.append(keystring);
    }
  }
  QString p_out;
  if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(), args,
                                &p_out) != 0) {
    return QList<UserInfo>();
  }
  return parseGpgColonOutput(p_out, secret);
}

/**
 * @brief Pass::listKeys list users
 * @param keystring
 * @param secret list private keys
 * @return QList<UserInfo> users
 */
auto Pass::listKeys(const QString &keystring, bool secret) -> QList<UserInfo> {
  return listKeys(QStringList(keystring), secret);
}

/**
 * @brief Pass::processFinished reemits specific signal based on what process
 * has finished
 * @param id    id of Pass process that was scheduled and finished
 * @param exitCode  return code of a process
 * @param out   output generated by process(if capturing was requested, empty
 *              otherwise)
 * @param err   error output generated by process(if capturing was requested,
 *              or error occurred)
 */
void Pass::finished(int id, int exitCode, const QString &out,
                    const QString &err) {
  auto pid = static_cast<PROCESS>(id);
  if (exitCode != 0) {
    emit processErrorExit(exitCode, err);
    return;
  }
  switch (pid) {
  case GIT_INIT:
    emit finishedGitInit(out, err);
    break;
  case GIT_PULL:
    emit finishedGitPull(out, err);
    break;
  case GIT_PUSH:
    emit finishedGitPush(out, err);
    break;
  case PASS_SHOW:
    emit finishedShow(out);
    break;
  case PASS_OTP_GENERATE:
    emit finishedOtpGenerate(out);
    break;
  case PASS_INSERT:
    emit finishedInsert(out, err);
    break;
  case PASS_REMOVE:
    emit finishedRemove(out, err);
    break;
  case PASS_INIT:
    emit finishedInit(out, err);
    break;
  case PASS_MOVE:
    emit finishedMove(out, err);
    break;
  case PASS_COPY:
    emit finishedCopy(out, err);
    break;
  case GPG_GENKEYS:
    emit finishedGenerateGPGKeys(out, err);
    break;
  default:
#ifdef QT_DEBUG
    dbg() << "Unhandled process type" << pid;
#endif
    break;
  }
}

/**
 * @brief Pass::updateEnv update the execution environment (used when
 * switching profiles)
 */
void Pass::updateEnv() {
  // put PASSWORD_STORE_SIGNING_KEY in env
  QStringList envSigningKey = env.filter("PASSWORD_STORE_SIGNING_KEY=");
  QString currentSigningKey = QtPassSettings::getPassSigningKey();
  if (envSigningKey.isEmpty()) {
    if (!currentSigningKey.isEmpty()) {
      // dbg()<< "Added
      // PASSWORD_STORE_SIGNING_KEY with" + currentSigningKey;
      env.append("PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);
    }
  } else {
    if (currentSigningKey.isEmpty()) {
      // dbg() << "Removed
      // PASSWORD_STORE_SIGNING_KEY";
      env.removeAll(envSigningKey.first());
    } else {
      // dbg()<< "Update
      // PASSWORD_STORE_SIGNING_KEY with " + currentSigningKey;
      env.replaceInStrings(envSigningKey.first(),
                           "PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);
    }
  }
  // put PASSWORD_STORE_DIR in env
  QStringList store = env.filter("PASSWORD_STORE_DIR=");
  if (store.isEmpty()) {
    // dbg()<< "Added
    // PASSWORD_STORE_DIR";
    env.append("PASSWORD_STORE_DIR=" + QtPassSettings::getPassStore());
  } else {
    // dbg()<< "Update
    // PASSWORD_STORE_DIR with " + passStore;
    env.replaceInStrings(store.first(), "PASSWORD_STORE_DIR=" +
                                            QtPassSettings::getPassStore());
  }
  exec.setEnvironment(env);
}

/**
 * @brief Pass::getGpgIdPath return gpgid file path for some file (folder).
 * @param for_file which file (folder) would you like the gpgid file path for.
 * @return path to the gpgid file.
 */
auto Pass::getGpgIdPath(const QString &for_file) -> QString {
  QString passStore =
      QDir::fromNativeSeparators(QtPassSettings::getPassStore());
  QString normalizedFile = QDir::fromNativeSeparators(for_file);
  QString fullPath = normalizedFile.startsWith(passStore)
                         ? normalizedFile
                         : passStore + "/" + normalizedFile;
  QDir gpgIdDir(QFileInfo(fullPath).absoluteDir());
  bool found = false;
  while (gpgIdDir.exists() && gpgIdDir.absolutePath().startsWith(passStore)) {
    if (QFile(gpgIdDir.absoluteFilePath(".gpg-id")).exists()) {
      found = true;
      break;
    }
    if (!gpgIdDir.cdUp()) {
      break;
    }
  }
  QString gpgIdPath(
      found ? gpgIdDir.absoluteFilePath(".gpg-id")
            : QDir(QtPassSettings::getPassStore()).filePath(".gpg-id"));

  return gpgIdPath;
}

/**
 * @brief Pass::getRecipientList return list of gpg-id's to encrypt for
 * @param for_file which file (folder) would you like recipients for
 * @return recipients gpg-id contents
 */
auto Pass::getRecipientList(const QString &for_file) -> QStringList {
  QFile gpgId(getGpgIdPath(for_file));
  if (!gpgId.open(QIODevice::ReadOnly | QIODevice::Text)) {
    return {};
  }
  QStringList recipients;
  while (!gpgId.atEnd()) {
    QString recipient(gpgId.readLine());
    recipient = recipient.split("#")[0].trimmed();
    if (!recipient.isEmpty()) {
      recipients += recipient;
    }
  }
  return recipients;
}

/**
 * @brief Pass::getRecipientString formatted string for use with GPG
 * @param for_file which file (folder) would you like recipients for
 * @param separator formating separator eg: " -r "
 * @param count
 * @return recipient string
 */
auto Pass::getRecipientString(const QString &for_file, const QString &separator,
                              int *count) -> QStringList {
  Q_UNUSED(separator)
  QStringList recipients = Pass::getRecipientList(for_file);
  if (count) {
    *count = recipients.size();
  }
  return recipients;
}

/* Copyright (C) 2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
 */

/**
 * @brief Generates a random number bounded by the given value.
 * @param bound Upper bound (exclusive)
 * @return Random number in range [0, bound)
 */
auto Pass::boundedRandom(quint32 bound) -> quint32 {
  if (bound < 2) {
    return 0;
  }

  quint32 randval;
  // Rejection-sampling threshold to avoid modulo bias:
  // In quint32 arithmetic, (1 + ~bound) wraps to (2^32 - bound), so
  // (1 + ~bound) % bound == 2^32 % bound.
  // Values randval < max_mod_bound are rejected; accepted values produce a
  // uniform distribution when reduced with (randval % bound).
  const quint32 max_mod_bound = (1 + ~bound) % bound;

  do {
    randval = QRandomGenerator::system()->generate();
  } while (randval < max_mod_bound);

  return randval % bound;
}

/**
 * @brief Generates a random password from the given charset.
 * @param charset Characters to use in the password
 * @param length Desired password length
 * @return Generated password string
 */
auto Pass::generateRandomPassword(const QString &charset, unsigned int length)
    -> QString {
  if (charset.isEmpty() || length == 0U) {
    return {};
  }
  QString out;
  for (unsigned int i = 0; i < length; ++i) {
    out.append(charset.at(static_cast<int>(
        boundedRandom(static_cast<quint32>(charset.length())))));
  }
  return out;
}

1	// SPDX-FileCopyrightText: 2016 Anne Jan Brouwer
2	// SPDX-License-Identifier: GPL-3.0-or-later
3	#include "pass.h"
4	#include "gpgkeystate.h"
5	#include "helpers.h"
6	#include "qtpasssettings.h"
7	#include "util.h"
8	#include <QDir>
9	#include <QFileInfo>
10	#include <QProcess>
11	#include <QRandomGenerator>
12	#include <QRegularExpression>
13	#include <utility>
14
15	#ifdef QT_DEBUG
16	#include "debughelper.h"
17	#endif
18
19	using Enums::GIT_INIT;
20	using Enums::GIT_PULL;
21	using Enums::GIT_PUSH;
22	using Enums::GPG_GENKEYS;
23	using Enums::PASS_COPY;
24	using Enums::PASS_INIT;
25	using Enums::PASS_INSERT;
26	using Enums::PASS_MOVE;
27	using Enums::PASS_OTP_GENERATE;
28	using Enums::PASS_REMOVE;
29	using Enums::PASS_SHOW;
30
31	/**
32	* @brief Pass::Pass wrapper for using either pass or the pass imitation
33	*/
34	Pass::Pass() : wrapperRunning(false), env(QProcess::systemEnvironment()) {	11✔
35	connect(&exec,	11✔
36	static_cast<void (Executor::*)(int, int, const QString &,
37	const QString &)>(&Executor::finished),
38	this, &Pass::finished);	11✔
39
40	// This was previously using direct QProcess signals.
41	// The code now uses Executor instead of raw QProcess for better control.
42	// connect(&process, SIGNAL(error(QProcess::ProcessError)), this,
43	// SIGNAL(error(QProcess::ProcessError)));
44
45	connect(&exec, &Executor::starting, this, &Pass::startingExecuteWrapper);	11✔
46	env.append("WSLENV=PASSWORD_STORE_DIR/p");	11✔
47	}	11✔
48
49	/**
50	* @brief Executes a wrapper command.
51	* @param id Process ID
52	* @param app Application to execute
53	* @param args Arguments
54	* @param readStdout Whether to read stdout
55	* @param readStderr Whether to read stderr
56	*/
57	void Pass::executeWrapper(PROCESS id, const QString &app,	×
58	const QStringList &args, bool readStdout,
59	bool readStderr) {
60	executeWrapper(id, app, args, QString(), readStdout, readStderr);	×
61	}	×
62
63	void Pass::executeWrapper(PROCESS id, const QString &app,	×
64	const QStringList &args, QString input,
65	bool readStdout, bool readStderr) {
66	#ifdef QT_DEBUG
67	dbg() << app << args;
68	#endif
69	exec.execute(id, QtPassSettings::getPassStore(), app, args, std::move(input),	×
70	readStdout, readStderr);
71	}	×
72
73	/**
74	* @brief Initializes the pass wrapper environment.
75	*/
76	void Pass::init() {	1✔
77	#ifdef __APPLE__
78	// If it exists, add the gpgtools to PATH
79	if (QFile("/usr/local/MacGPG2/bin").exists())
80	env.replaceInStrings("PATH=", "PATH=/usr/local/MacGPG2/bin:");
81	// Add missing /usr/local/bin
82	if (env.filter("/usr/local/bin").isEmpty())
83	env.replaceInStrings("PATH=", "PATH=/usr/local/bin:");
84	#endif
85
86	if (!QtPassSettings::getGpgHome().isEmpty()) {	2✔
87	QDir absHome(QtPassSettings::getGpgHome());	×
88	absHome.makeAbsolute();	×
89	env << "GNUPGHOME=" + absHome.path();	×
90	}	×
91	}	1✔
92
93	/**
94	* @brief Pass::Generate use either pwgen or internal password
95	* generator
96	* @param length of the desired password
97	* @param charset to use for generation
98	* @return the password
99	*/
100	auto Pass::generatePassword(unsigned int length, const QString &charset)	1,004✔
101	-> QString {
102	QString passwd;	1,004✔
103	if (QtPassSettings::isUsePwgen()) {	1,004✔
104	// --secure goes first as it overrides --no-* otherwise
105	QStringList args;	×
106	args.append("-1");	×
107	if (!QtPassSettings::isLessRandom()) {	×
108	args.append("--secure");	×
109	}
110	args.append(QtPassSettings::isAvoidCapitals() ? "--no-capitalize"	×
111	: "--capitalize");
112	args.append(QtPassSettings::isAvoidNumbers() ? "--no-numerals"	×
113	: "--numerals");
114	if (QtPassSettings::isUseSymbols()) {	×
115	args.append("--symbols");	×
116	}
117	args.append(QString::number(length));	×
118	// executeBlocking returns 0 on success, non-zero on failure
119	if (Executor::executeBlocking(QtPassSettings::getPwgenExecutable(), args,	×
120	&passwd) == 0) {
121	static const QRegularExpression literalNewLines{"[\\n\\r]"};	×
122	passwd.remove(literalNewLines);	×
123	} else {
124	passwd.clear();	×
125	#ifdef QT_DEBUG
126	qDebug() << __FILE__ << ":" << __LINE__ << "\t"
127	<< "pwgen fail";
128	#endif
129	// Error is already handled by clearing passwd; no need for critical
130	// signal here
131	}
132	} else {
133	// Validate charset - if CUSTOM is selected but chars are empty,
134	// fall back to ALLCHARS to prevent weak passwords (issue #780)
135	QString effectiveCharset = charset;
136	if (effectiveCharset.isEmpty()) {	1,004✔
137	effectiveCharset = QtPassSettings::getPasswordConfiguration()	2✔
138	.Characters[PasswordConfiguration::ALLCHARS];
139	}
140	if (effectiveCharset.length() > 0) {	1,004✔
141	passwd = generateRandomPassword(effectiveCharset, length);	2,008✔
142	} else {
143	emit critical(	×
144	tr("No characters chosen"),	×
145	tr("Can't generate password, there are no characters to choose from "	×
146	"set in the configuration!"));
147	}
148	}
149	return passwd;	1,004✔
150	}
151
152	/**
153	* @brief Pass::gpgSupportsEd25519 check if GPG supports ed25519 (ECC)
154	* GPG 2.1+ supports ed25519 which is much faster for key generation
155	* @return true if ed25519 is supported
156	*/
157	bool Pass::gpgSupportsEd25519() {	3✔
158	QString out, err;	3✔
159	if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(),	12✔
160	{"--version"}, &out, &err) != 0) {
161	return false;
162	}
163	QRegularExpression versionRegex(R"(gpg \(GnuPG\) (\d+)\.(\d+))");	×
164	QRegularExpressionMatch match = versionRegex.match(out);	×
165	if (!match.hasMatch()) {	×
166	return false;
167	}
168	int major = match.captured(1).toInt();	×
169	int minor = match.captured(2).toInt();	×
170	return major > 2 \|\| (major == 2 && minor >= 1);	×
171	}	3✔
172
173	/**
174	* @brief Pass::getDefaultKeyTemplate return default key generation template
175	* Uses ed25519 if supported, otherwise falls back to RSA
176	* @return GPG batch template string
177	*/
178	QString Pass::getDefaultKeyTemplate() {	1✔
179	if (gpgSupportsEd25519()) {	1✔
180	return QStringLiteral("%echo Generating a default key\n"	×
181	"Key-Type: EdDSA\n"
182	"Key-Curve: Ed25519\n"
183	"Subkey-Type: ECDH\n"
184	"Subkey-Curve: Curve25519\n"
185	"Name-Real: \n"
186	"Name-Comment: QtPass\n"
187	"Name-Email: \n"
188	"Expire-Date: 0\n"
189	"%no-protection\n"
190	"%commit\n"
191	"%echo done");
192	}
193	return QStringLiteral("%echo Generating a default key\n"	1✔
194	"Key-Type: RSA\n"
195	"Subkey-Type: RSA\n"
196	"Name-Real: \n"
197	"Name-Comment: QtPass\n"
198	"Name-Email: \n"
199	"Expire-Date: 0\n"
200	"%no-protection\n"
201	"%commit\n"
202	"%echo done");
203	}
204
205	namespace {
206	auto resolveWslGpgconfPath(const QString &lastPart) -> QString {	3✔
207	int lastSep = lastPart.lastIndexOf('/');	3✔
208	if (lastSep < 0) {	3✔
209	lastSep = lastPart.lastIndexOf('\\');	2✔
210	}
211	if (lastSep >= 0) {	2✔
212	return lastPart.left(lastSep + 1) + "gpgconf";	2✔
213	}
214	return QStringLiteral("gpgconf");	2✔
215	}
216
217	QString findGpgconfInGpgDir(const QString &gpgPath) {	1✔
218	QFileInfo gpgInfo(gpgPath);	1✔
219	if (!gpgInfo.isAbsolute()) {	1✔
220	return QString();
221	}
222
223	QDir dir(gpgInfo.absolutePath());	1✔
224
225	#ifdef Q_OS_WIN
226	QFileInfo candidateExe(dir.filePath("gpgconf.exe"));
227	if (candidateExe.isExecutable()) {
228	return candidateExe.filePath();
229	}
230	#endif
231
232	QFileInfo candidate(dir.filePath("gpgconf"));	1✔
233	if (candidate.isExecutable()) {	1✔
234	return candidate.filePath();	1✔
235	}
236	return QString();
237	}	1✔
238	} // namespace
239
240	auto Pass::resolveGpgconfCommand(const QString &gpgPath)	8✔
241	-> ResolvedGpgconfCommand {
242	if (gpgPath.trimmed().isEmpty()) {	8✔
243	return {"gpgconf", {}};
244	}
245
246	#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
247	QStringList parts = QProcess::splitCommand(gpgPath);	7✔
248	#else
249	QStringList splitCommandCompat(const QString &command) {
250	QStringList result;
251	QString current;
252	bool inSingleQuote = false;
253	bool inDoubleQuote = false;
254	bool escaping = false;
255	for (QChar ch : command) {
256	if (escaping) {
257	current.append(ch);
258	escaping = false;
259	continue;
260	}
261	if (ch == '\\') {
262	escaping = true;
263	continue;
264	}
265	if (ch == '\'' && !inDoubleQuote) {
266	inSingleQuote = !inSingleQuote;
267	continue;
268	}
269	if (ch == '"' && !inSingleQuote) {
270	inDoubleQuote = !inDoubleQuote;
271	continue;
272	}
273	if (ch.isSpace() && !inSingleQuote && !inDoubleQuote) {
274	if (!current.isEmpty()) {
275	result.append(current);
276	current.clear();
277	}
278	continue;
279	}
280	current.append(ch);
281	}
282	if (escaping) {
283	current.append('\\');
284	}
285	if (!current.isEmpty()) {
286	result.append(current);
287	}
288	return result;
289	}
290	QStringList parts = splitCommandCompat(gpgPath);
291	#endif
292
293	if (parts.isEmpty()) {	7✔
294	return {"gpgconf", {}};
295	}
296
297	const QString first = parts.first();
298	if (first == "wsl" \|\| first == "wsl.exe") {	9✔
299	if (parts.size() >= 2 && parts.at(1).startsWith("sh")) {	9✔
300	return {"gpgconf", {}};
301	}
302	if (parts.size() >= 2 &&	4✔
303	QFileInfo(parts.last()).fileName().startsWith("gpg")) {	10✔
304	QString wslGpgconf = resolveWslGpgconfPath(parts.last());	3✔
305	parts.removeLast();	3✔
306	parts.append(wslGpgconf);
307	return {parts.first(), parts.mid(1)};
308	}
309	return {"gpgconf", {}};
310	}
311
312	if (!first.contains('/') && !first.contains('\\')) {	2✔
313	return {"gpgconf", {}};
314	}
315
316	QString gpgconfPath = findGpgconfInGpgDir(gpgPath);	1✔
317	if (!gpgconfPath.isEmpty()) {	1✔
318	return {gpgconfPath, {}};	1✔
319	}
320
321	return {"gpgconf", {}};
322	}	8✔
323
324	/**
325	* @brief Pass::GenerateGPGKeys internal gpg keypair generator . .
326	* @param batch GnuPG style configuration string
327	*/
UNCOV 328	void Pass::GenerateGPGKeys(QString batch) {	×
329	// Kill any stale GPG agents that might be holding locks on the key database
330	// This helps avoid "database locked" timeouts during key generation
UNCOV 331	QString gpgPath = QtPassSettings::getGpgExecutable();	×
332	if (!gpgPath.isEmpty()) {	×
333	ResolvedGpgconfCommand gpgconf = resolveGpgconfCommand(gpgPath);	×
334	QStringList killArgs = gpgconf.arguments;
UNCOV 335	killArgs << "--kill";	×
336	killArgs << "gpg-agent";	×
337	// Use same environment as key generation to target correct gpg-agent
UNCOV 338	Executor::executeBlocking(env, gpgconf.program, killArgs);	×
339	}
340
UNCOV 341	executeWrapper(GPG_GENKEYS, gpgPath, {"--gen-key", "--no-tty", "--batch"},	×
342	std::move(batch));
UNCOV 343	}	×
344
345	/**
346	* @brief Pass::listKeys list users
347	* @param keystrings
348	* @param secret list private keys
349	* @return QList<UserInfo> users
350	*/
UNCOV 351	auto Pass::listKeys(QStringList keystrings, bool secret) -> QList<UserInfo> {	×
352	QStringList args = {"--no-tty", "--with-colons", "--with-fingerprint"};	×
353	args.append(secret ? "--list-secret-keys" : "--list-keys");	×
354
UNCOV 355	for (const QString &keystring : AS_CONST(keystrings)) {	×
356	if (!keystring.isEmpty()) {	×
357	args.append(keystring);
358	}
359	}
UNCOV 360	QString p_out;	×
361	if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(), args,	×
362	&p_out) != 0) {
UNCOV 363	return QList<UserInfo>();	×
364	}
UNCOV 365	return parseGpgColonOutput(p_out, secret);	×
366	}	×
367
368	/**
369	* @brief Pass::listKeys list users
370	* @param keystring
371	* @param secret list private keys
372	* @return QList<UserInfo> users
373	*/
UNCOV 374	auto Pass::listKeys(const QString &keystring, bool secret) -> QList<UserInfo> {	×
375	return listKeys(QStringList(keystring), secret);	×
376	}
377
378	/**
379	* @brief Pass::processFinished reemits specific signal based on what process
380	* has finished
381	* @param id id of Pass process that was scheduled and finished
382	* @param exitCode return code of a process
383	* @param out output generated by process(if capturing was requested, empty
384	* otherwise)
385	* @param err error output generated by process(if capturing was requested,
386	* or error occurred)
387	*/
UNCOV 388	void Pass::finished(int id, int exitCode, const QString &out,	×
389	const QString &err) {
390	auto pid = static_cast<PROCESS>(id);
UNCOV 391	if (exitCode != 0) {	×
392	emit processErrorExit(exitCode, err);	×
393	return;	×
394	}
UNCOV 395	switch (pid) {	×
396	case GIT_INIT:	×
397	emit finishedGitInit(out, err);	×
398	break;	×
399	case GIT_PULL:	×
400	emit finishedGitPull(out, err);	×
401	break;	×
402	case GIT_PUSH:	×
403	emit finishedGitPush(out, err);	×
404	break;	×
405	case PASS_SHOW:	×
406	emit finishedShow(out);	×
407	break;	×
408	case PASS_OTP_GENERATE:	×
409	emit finishedOtpGenerate(out);	×
410	break;	×
411	case PASS_INSERT:	×
412	emit finishedInsert(out, err);	×
413	break;	×
414	case PASS_REMOVE:	×
415	emit finishedRemove(out, err);	×
416	break;	×
417	case PASS_INIT:	×
418	emit finishedInit(out, err);	×
419	break;	×
420	case PASS_MOVE:	×
421	emit finishedMove(out, err);	×
422	break;	×
423	case PASS_COPY:	×
424	emit finishedCopy(out, err);	×
425	break;	×
426	case GPG_GENKEYS:	×
427	emit finishedGenerateGPGKeys(out, err);	×
428	break;	×
429	default:
430	#ifdef QT_DEBUG
431	dbg() << "Unhandled process type" << pid;
432	#endif
433	break;
434	}
435	}
436
437	/**
438	* @brief Pass::updateEnv update the execution environment (used when
439	* switching profiles)
440	*/
UNCOV 441	void Pass::updateEnv() {	×
442	// put PASSWORD_STORE_SIGNING_KEY in env
UNCOV 443	QStringList envSigningKey = env.filter("PASSWORD_STORE_SIGNING_KEY=");	×
444	QString currentSigningKey = QtPassSettings::getPassSigningKey();	×
445	if (envSigningKey.isEmpty()) {	×
446	if (!currentSigningKey.isEmpty()) {	×
447	// dbg()<< "Added
448	// PASSWORD_STORE_SIGNING_KEY with" + currentSigningKey;
UNCOV 449	env.append("PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);	×
450	}
451	} else {
UNCOV 452	if (currentSigningKey.isEmpty()) {	×
453	// dbg() << "Removed
454	// PASSWORD_STORE_SIGNING_KEY";
455	env.removeAll(envSigningKey.first());
456	} else {
457	// dbg()<< "Update
458	// PASSWORD_STORE_SIGNING_KEY with " + currentSigningKey;
UNCOV 459	env.replaceInStrings(envSigningKey.first(),	×
460	"PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);	×
461	}
462	}
463	// put PASSWORD_STORE_DIR in env
UNCOV 464	QStringList store = env.filter("PASSWORD_STORE_DIR=");	×
465	if (store.isEmpty()) {	×
466	// dbg()<< "Added
467	// PASSWORD_STORE_DIR";
UNCOV 468	env.append("PASSWORD_STORE_DIR=" + QtPassSettings::getPassStore());	×
469	} else {
470	// dbg()<< "Update
471	// PASSWORD_STORE_DIR with " + passStore;
UNCOV 472	env.replaceInStrings(store.first(), "PASSWORD_STORE_DIR=" +	×
473	QtPassSettings::getPassStore());	×
474	}
UNCOV 475	exec.setEnvironment(env);	×
476	}	×
477
478	/**
479	* @brief Pass::getGpgIdPath return gpgid file path for some file (folder).
480	* @param for_file which file (folder) would you like the gpgid file path for.
481	* @return path to the gpgid file.
482	*/
483	auto Pass::getGpgIdPath(const QString &for_file) -> QString {	8✔
484	QString passStore =
485	QDir::fromNativeSeparators(QtPassSettings::getPassStore());	16✔
486	QString normalizedFile = QDir::fromNativeSeparators(for_file);	8✔
487	QString fullPath = normalizedFile.startsWith(passStore)	8✔
488	? normalizedFile	8✔
489	: passStore + "/" + normalizedFile;	6✔
490	QDir gpgIdDir(QFileInfo(fullPath).absoluteDir());	8✔
491	bool found = false;
492	while (gpgIdDir.exists() && gpgIdDir.absolutePath().startsWith(passStore)) {	10✔
493	if (QFile(gpgIdDir.absoluteFilePath(".gpg-id")).exists()) {	2✔
494	found = true;
495	break;
496	}
UNCOV 497	if (!gpgIdDir.cdUp()) {	×
498	break;
499	}
500	}
501	QString gpgIdPath(
502	found ? gpgIdDir.absoluteFilePath(".gpg-id")	8✔
503	: QDir(QtPassSettings::getPassStore()).filePath(".gpg-id"));	29✔
504
505	return gpgIdPath;	8✔
506	}	8✔
507
508	/**
509	* @brief Pass::getRecipientList return list of gpg-id's to encrypt for
510	* @param for_file which file (folder) would you like recipients for
511	* @return recipients gpg-id contents
512	*/
513	auto Pass::getRecipientList(const QString &for_file) -> QStringList {	5✔
514	QFile gpgId(getGpgIdPath(for_file));	5✔
515	if (!gpgId.open(QIODevice::ReadOnly \| QIODevice::Text)) {	5✔
UNCOV 516	return {};	×
517	}
518	QStringList recipients;	5✔
519	while (!gpgId.atEnd()) {	14✔
520	QString recipient(gpgId.readLine());	18✔
521	recipient = recipient.split("#")[0].trimmed();	18✔
522	if (!recipient.isEmpty()) {	9✔
523	recipients += recipient;
524	}
525	}
526	return recipients;
527	}	5✔
528
529	/**
530	* @brief Pass::getRecipientString formatted string for use with GPG
531	* @param for_file which file (folder) would you like recipients for
532	* @param separator formating separator eg: " -r "
533	* @param count
534	* @return recipient string
535	*/
536	auto Pass::getRecipientString(const QString &for_file, const QString &separator,	2✔
537	int *count) -> QStringList {
538	Q_UNUSED(separator)
539	QStringList recipients = Pass::getRecipientList(for_file);	2✔
540	if (count) {	2✔
541	*count = recipients.size();	1✔
542	}
543	return recipients;	2✔
544	}
545
546	/* Copyright (C) 2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
547	*/
548
549	/**
550	* @brief Generates a random number bounded by the given value.
551	* @param bound Upper bound (exclusive)
552	* @return Random number in range [0, bound)
553	*/
554	auto Pass::boundedRandom(quint32 bound) -> quint32 {	1,160✔
555	if (bound < 2) {	1,160✔
556	return 0;
557	}
558
559	quint32 randval;
560	// Rejection-sampling threshold to avoid modulo bias:
561	// In quint32 arithmetic, (1 + ~bound) wraps to (2^32 - bound), so
562	// (1 + ~bound) % bound == 2^32 % bound.
563	// Values randval < max_mod_bound are rejected; accepted values produce a
564	// uniform distribution when reduced with (randval % bound).
565	const quint32 max_mod_bound = (1 + ~bound) % bound;	1,160✔
566
567	do {
568	randval = QRandomGenerator::system()->generate();
569	} while (randval < max_mod_bound);	1,160✔
570
571	return randval % bound;	1,160✔
572	}
573
574	/**
575	* @brief Generates a random password from the given charset.
576	* @param charset Characters to use in the password
577	* @param length Desired password length
578	* @return Generated password string
579	*/
580	auto Pass::generateRandomPassword(const QString &charset, unsigned int length)	1,004✔
581	-> QString {
582	if (charset.isEmpty() \|\| length == 0U) {	1,004✔
583	return {};
584	}
585	QString out;	1,003✔
586	for (unsigned int i = 0; i < length; ++i) {	2,163✔
587	out.append(charset.at(static_cast<int>(	1,160✔
588	boundedRandom(static_cast<quint32>(charset.length())))));	1,160✔
589	}
590	return out;
591	}

IJHack / QtPass / 24103090537

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous