24097698361

Committed 07 Apr 2026 06:27PM UTC coverage: 20.293% (+0.07%) from 20.222%

Build # 24097698361

Build Type

Pull #900

github

Committed by

web-flow

Commit Message

Merge ec163d606 into 85a69d0b9

Pull Request Pull Request #900: fix: spelling corrections and code quality improvements

Coverage Stats

11 of 32 new or added lines in 2 files covered. (34.38%)

7 existing lines in 1 file now uncovered.

1065 of 5248 relevant lines covered (20.29%)

7.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

42.36

/src/pass.cpp

// SPDX-FileCopyrightText: 2016 Anne Jan Brouwer
// SPDX-License-Identifier: GPL-3.0-or-later
#include "pass.h"
#include "helpers.h"
#include "qtpasssettings.h"
#include "util.h"
#include <QDir>
#include <QFileInfo>
#include <QProcess>
#include <QRandomGenerator>
#include <QRegularExpression>
#include <utility>

#ifdef QT_DEBUG
#include "debughelper.h"
#endif

using Enums::GIT_INIT;
using Enums::GIT_PULL;
using Enums::GIT_PUSH;
using Enums::GPG_GENKEYS;
using Enums::PASS_COPY;
using Enums::PASS_INIT;
using Enums::PASS_INSERT;
using Enums::PASS_MOVE;
using Enums::PASS_OTP_GENERATE;
using Enums::PASS_REMOVE;
using Enums::PASS_SHOW;

/**
 * @brief Pass::Pass wrapper for using either pass or the pass imitation
 */
Pass::Pass() : wrapperRunning(false), env(QProcess::systemEnvironment()) {
  connect(&exec,
          static_cast<void (Executor::*)(int, int, const QString &,
                                         const QString &)>(&Executor::finished),
          this, &Pass::finished);

  // This was previously using direct QProcess signals.
  // The code now uses Executor instead of raw QProcess for better control.
  // connect(&process, SIGNAL(error(QProcess::ProcessError)), this,
  //        SIGNAL(error(QProcess::ProcessError)));

  connect(&exec, &Executor::starting, this, &Pass::startingExecuteWrapper);
  env.append("WSLENV=PASSWORD_STORE_DIR/p");
}

/**
 * @brief Executes a wrapper command.
 * @param id Process ID
 * @param app Application to execute
 * @param args Arguments
 * @param readStdout Whether to read stdout
 * @param readStderr Whether to read stderr
 */
void Pass::executeWrapper(PROCESS id, const QString &app,
                          const QStringList &args, bool readStdout,
                          bool readStderr) {
  executeWrapper(id, app, args, QString(), readStdout, readStderr);
}

void Pass::executeWrapper(PROCESS id, const QString &app,
                          const QStringList &args, QString input,
                          bool readStdout, bool readStderr) {
#ifdef QT_DEBUG
  dbg() << app << args;
#endif
  exec.execute(id, QtPassSettings::getPassStore(), app, args, std::move(input),
               readStdout, readStderr);
}

/**
 * @brief Initializes the pass wrapper environment.
 */
void Pass::init() {
#ifdef __APPLE__
  // If it exists, add the gpgtools to PATH
  if (QFile("/usr/local/MacGPG2/bin").exists())
    env.replaceInStrings("PATH=", "PATH=/usr/local/MacGPG2/bin:");
  // Add missing /usr/local/bin
  if (env.filter("/usr/local/bin").isEmpty())
    env.replaceInStrings("PATH=", "PATH=/usr/local/bin:");
#endif

  if (!QtPassSettings::getGpgHome().isEmpty()) {
    QDir absHome(QtPassSettings::getGpgHome());
    absHome.makeAbsolute();
    env << "GNUPGHOME=" + absHome.path();
  }
}

/**
 * @brief Pass::Generate use either pwgen or internal password
 * generator
 * @param length of the desired password
 * @param charset to use for generation
 * @return the password
 */
auto Pass::generatePassword(unsigned int length, const QString &charset)
    -> QString {
  QString passwd;
  if (QtPassSettings::isUsePwgen()) {
    // --secure goes first as it overrides --no-* otherwise
    QStringList args;
    args.append("-1");
    if (!QtPassSettings::isLessRandom()) {
      args.append("--secure");
    }
    args.append(QtPassSettings::isAvoidCapitals() ? "--no-capitalize"
                                                  : "--capitalize");
    args.append(QtPassSettings::isAvoidNumbers() ? "--no-numerals"
                                                 : "--numerals");
    if (QtPassSettings::isUseSymbols()) {
      args.append("--symbols");
    }
    args.append(QString::number(length));
    // executeBlocking returns 0 on success, non-zero on failure
    if (Executor::executeBlocking(QtPassSettings::getPwgenExecutable(), args,
                                  &passwd) == 0) {
      static const QRegularExpression literalNewLines{"[\\n\\r]"};
      passwd.remove(literalNewLines);
    } else {
      passwd.clear();
#ifdef QT_DEBUG
      qDebug() << __FILE__ << ":" << __LINE__ << "\t"
               << "pwgen fail";
#endif
      // Error is already handled by clearing passwd; no need for critical
      // signal here
    }
  } else {
    // Validate charset - if CUSTOM is selected but chars are empty,
    // fall back to ALLCHARS to prevent weak passwords (issue #780)
    QString effectiveCharset = charset;
    if (effectiveCharset.isEmpty()) {
      effectiveCharset = QtPassSettings::getPasswordConfiguration()
                             .Characters[PasswordConfiguration::ALLCHARS];
    }
    if (effectiveCharset.length() > 0) {
      passwd = generateRandomPassword(effectiveCharset, length);
    } else {
      emit critical(
          tr("No characters chosen"),
          tr("Can't generate password, there are no characters to choose from "
             "set in the configuration!"));
    }
  }
  return passwd;
}

/**
 * @brief Pass::gpgSupportsEd25519 check if GPG supports ed25519 (ECC)
 * GPG 2.1+ supports ed25519 which is much faster for key generation
 * @return true if ed25519 is supported
 */
bool Pass::gpgSupportsEd25519() {
  QString out, err;
  if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(),
                                {"--version"}, &out, &err) != 0) {
    return false;
  }
  QRegularExpression versionRegex(R"(gpg \(GnuPG\) (\d+)\.(\d+))");
  QRegularExpressionMatch match = versionRegex.match(out);
  if (!match.hasMatch()) {
    return false;
  }
  int major = match.captured(1).toInt();
  int minor = match.captured(2).toInt();
  return major > 2 || (major == 2 && minor >= 1);
}

/**
 * @brief Pass::getDefaultKeyTemplate return default key generation template
 * Uses ed25519 if supported, otherwise falls back to RSA
 * @return GPG batch template string
 */
QString Pass::getDefaultKeyTemplate() {
  if (gpgSupportsEd25519()) {
    return QStringLiteral("%echo Generating a default key\n"
                          "Key-Type: EdDSA\n"
                          "Key-Curve: Ed25519\n"
                          "Subkey-Type: ECDH\n"
                          "Subkey-Curve: Curve25519\n"
                          "Name-Real: \n"
                          "Name-Comment: QtPass\n"
                          "Name-Email: \n"
                          "Expire-Date: 0\n"
                          "%no-protection\n"
                          "%commit\n"
                          "%echo done");
  }
  return QStringLiteral("%echo Generating a default key\n"
                        "Key-Type: RSA\n"
                        "Subkey-Type: RSA\n"
                        "Name-Real: \n"
                        "Name-Comment: QtPass\n"
                        "Name-Email: \n"
                        "Expire-Date: 0\n"
                        "%no-protection\n"
                        "%commit\n"
                        "%echo done");
}

namespace {
auto resolveWslGpgconfPath(const QString &lastPart) -> QString {
  int lastSep = lastPart.lastIndexOf('/');
  if (lastSep < 0) {
    lastSep = lastPart.lastIndexOf('\\');
  }
  if (lastSep >= 0) {
    return lastPart.left(lastSep + 1) + "gpgconf";
  }
  return QStringLiteral("gpgconf");
}

QString findGpgconfInGpgDir(const QString &gpgPath) {
  QFileInfo gpgInfo(gpgPath);
  if (!gpgInfo.isAbsolute()) {
    return QString();
  }

  QDir dir(gpgInfo.absolutePath());

#ifdef Q_OS_WIN
  QFileInfo candidateExe(dir.filePath("gpgconf.exe"));
  if (candidateExe.isExecutable()) {
    return candidateExe.filePath();
  }
#endif

  QFileInfo candidate(dir.filePath("gpgconf"));
  if (candidate.isExecutable()) {
    return candidate.filePath();
  }
  return QString();
}
} // namespace

namespace {
auto resolveWslGpgconf(const QStringList &parts) -> ResolvedGpgconfCommand {
  if (parts.size() >= 2 && parts.at(1).startsWith("sh")) {
    return {"gpgconf", {}};
  }
  for (int i = 1; i < parts.size(); ++i) {
    const QString baseName = QFileInfo(parts.at(i)).fileName();
    if (baseName == "gpg" || baseName == "gpg.exe" || baseName == "gpg2" ||
        baseName == "gpg2.exe") {
      QStringList newParts = parts;
      newParts[i] = resolveWslGpgconfPath(parts.at(i));
      return {newParts.first(), newParts.mid(1)};
    }
  }
  return {"gpgconf", {}};
}
} // namespace

auto Pass::resolveGpgconfCommand(const QString &gpgPath)
    -> ResolvedGpgconfCommand {
  if (gpgPath.trimmed().isEmpty()) {
    return {"gpgconf", {}};
  }

#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
  QStringList parts = QProcess::splitCommand(gpgPath);
#else
  QStringList parts = QStringList{gpgPath};
#endif

  if (parts.isEmpty()) {
    return {"gpgconf", {}};
  }

  const QString first = parts.first();
  if (first == "wsl" || first == "wsl.exe") {
    return resolveWslGpgconf(parts);
  }

  if (!gpgPath.contains('/') && !gpgPath.contains('\\')) {
    return {"gpgconf", {}};
  }

  QString gpgconfPath = findGpgconfInGpgDir(gpgPath);
  if (!gpgconfPath.isEmpty()) {
    return {gpgconfPath, {}};
  }

  return {"gpgconf", {}};
}

/**
 * @brief Pass::GenerateGPGKeys internal gpg keypair generator . .
 * @param batch GnuPG style configuration string
 */
void Pass::GenerateGPGKeys(QString batch) {
  // Kill any stale GPG agents that might be holding locks on the key database
  // This helps avoid "database locked" timeouts during key generation
  QString gpgPath = QtPassSettings::getGpgExecutable();
  if (!gpgPath.isEmpty()) {
    ResolvedGpgconfCommand gpgconf = resolveGpgconfCommand(gpgPath);
    QStringList killArgs = gpgconf.arguments;
    killArgs << "--kill";
    killArgs << "gpg-agent";
    // Use same environment as key generation to target correct gpg-agent
    Executor::executeBlocking(env, gpgconf.program, killArgs);
  }

  executeWrapper(GPG_GENKEYS, gpgPath, {"--gen-key", "--no-tty", "--batch"},
                 std::move(batch));
}

/**
 * @brief Pass::listKeys list users
 * @param keystrings
 * @param secret list private keys
 * @return QList<UserInfo> users
 */
auto Pass::listKeys(QStringList keystrings, bool secret) -> QList<UserInfo> {
  QList<UserInfo> users;
  QStringList args = {"--no-tty", "--with-colons", "--with-fingerprint"};
  args.append(secret ? "--list-secret-keys" : "--list-keys");

  for (const QString &keystring : AS_CONST(keystrings)) {
    if (!keystring.isEmpty()) {
      args.append(keystring);
    }
  }
  QString p_out;
  if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(), args,
                                &p_out) != 0) {
    return users;
  }
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
  const QStringList keys =
      p_out.split(Util::newLinesRegex(), Qt::SkipEmptyParts);
#else
  const QStringList keys =
      p_out.split(Util::newLinesRegex(), QString::SkipEmptyParts);
#endif
  UserInfo current_user;
  constexpr int GPG_MIN_FIELDS = 10;
  constexpr int GPG_FIELD_VALIDITY = 1;
  constexpr int GPG_FIELD_KEY_ID = 4;
  constexpr int GPG_FIELD_CREATED = 5;
  constexpr int GPG_FIELD_EXPIRY = 6;
  constexpr int GPG_FIELD_USERID = 9;
  for (const QString &key : keys) {
    QStringList props = key.split(':');
    if (props.size() < GPG_MIN_FIELDS) {
      continue;
    }
    if (props[0] == (secret ? "sec" : "pub")) {
      if (!current_user.key_id.isEmpty()) {
        users.append(current_user);
      }
      current_user = UserInfo();
      current_user.key_id = props[GPG_FIELD_KEY_ID];
      current_user.name = props[GPG_FIELD_USERID].toUtf8();
      current_user.validity = props[GPG_FIELD_VALIDITY][0].toLatin1();
      bool okCreated = false;
      const qint64 createdSecs =
          props[GPG_FIELD_CREATED].toLongLong(&okCreated);
      if (okCreated) {
        current_user.created.setSecsSinceEpoch(createdSecs);
      }
      bool okExpiry = false;
      const qint64 expirySecs = props[GPG_FIELD_EXPIRY].toLongLong(&okExpiry);
      if (okExpiry) {
        current_user.expiry.setSecsSinceEpoch(expirySecs);
      }
    } else if (current_user.name.isEmpty() && props[0] == "uid") {
      current_user.name = props[GPG_FIELD_USERID];
    } else if ((props[0] == "fpr") &&
               props[GPG_FIELD_USERID].endsWith(current_user.key_id)) {
      current_user.key_id = props[GPG_FIELD_USERID];
    }
  }
  if (!current_user.key_id.isEmpty()) {
    users.append(current_user);
  }
  return users;
}

/**
 * @brief Pass::listKeys list users
 * @param keystring
 * @param secret list private keys
 * @return QList<UserInfo> users
 */
auto Pass::listKeys(const QString &keystring, bool secret) -> QList<UserInfo> {
  return listKeys(QStringList(keystring), secret);
}

/**
 * @brief Pass::processFinished reemits specific signal based on what process
 * has finished
 * @param id    id of Pass process that was scheduled and finished
 * @param exitCode  return code of a process
 * @param out   output generated by process(if capturing was requested, empty
 *              otherwise)
 * @param err   error output generated by process(if capturing was requested,
 *              or error occurred)
 */
void Pass::finished(int id, int exitCode, const QString &out,
                    const QString &err) {
  auto pid = static_cast<PROCESS>(id);
  if (exitCode != 0) {
    emit processErrorExit(exitCode, err);
    return;
  }
  switch (pid) {
  case GIT_INIT:
    emit finishedGitInit(out, err);
    break;
  case GIT_PULL:
    emit finishedGitPull(out, err);
    break;
  case GIT_PUSH:
    emit finishedGitPush(out, err);
    break;
  case PASS_SHOW:
    emit finishedShow(out);
    break;
  case PASS_OTP_GENERATE:
    emit finishedOtpGenerate(out);
    break;
  case PASS_INSERT:
    emit finishedInsert(out, err);
    break;
  case PASS_REMOVE:
    emit finishedRemove(out, err);
    break;
  case PASS_INIT:
    emit finishedInit(out, err);
    break;
  case PASS_MOVE:
    emit finishedMove(out, err);
    break;
  case PASS_COPY:
    emit finishedCopy(out, err);
    break;
  case GPG_GENKEYS:
    emit finishedGenerateGPGKeys(out, err);
    break;
  default:
#ifdef QT_DEBUG
    dbg() << "Unhandled process type" << pid;
#endif
    break;
  }
}

/**
 * @brief Pass::updateEnv update the execution environment (used when
 * switching profiles)
 */
void Pass::updateEnv() {
  // put PASSWORD_STORE_SIGNING_KEY in env
  QStringList envSigningKey = env.filter("PASSWORD_STORE_SIGNING_KEY=");
  QString currentSigningKey = QtPassSettings::getPassSigningKey();
  if (envSigningKey.isEmpty()) {
    if (!currentSigningKey.isEmpty()) {
      // dbg()<< "Added
      // PASSWORD_STORE_SIGNING_KEY with" + currentSigningKey;
      env.append("PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);
    }
  } else {
    if (currentSigningKey.isEmpty()) {
      // dbg() << "Removed
      // PASSWORD_STORE_SIGNING_KEY";
      env.removeAll(envSigningKey.first());
    } else {
      // dbg()<< "Update
      // PASSWORD_STORE_SIGNING_KEY with " + currentSigningKey;
      env.replaceInStrings(envSigningKey.first(),
                           "PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);
    }
  }
  // put PASSWORD_STORE_DIR in env
  QStringList store = env.filter("PASSWORD_STORE_DIR=");
  if (store.isEmpty()) {
    // dbg()<< "Added
    // PASSWORD_STORE_DIR";
    env.append("PASSWORD_STORE_DIR=" + QtPassSettings::getPassStore());
  } else {
    // dbg()<< "Update
    // PASSWORD_STORE_DIR with " + passStore;
    env.replaceInStrings(store.first(), "PASSWORD_STORE_DIR=" +
                                            QtPassSettings::getPassStore());
  }
  exec.setEnvironment(env);
}

/**
 * @brief Pass::getGpgIdPath return gpgid file path for some file (folder).
 * @param for_file which file (folder) would you like the gpgid file path for.
 * @return path to the gpgid file.
 */
auto Pass::getGpgIdPath(const QString &for_file) -> QString {
  QString passStore =
      QDir::fromNativeSeparators(QtPassSettings::getPassStore());
  QString normalizedFile = QDir::fromNativeSeparators(for_file);
  QString fullPath = normalizedFile.startsWith(passStore)
                         ? normalizedFile
                         : passStore + "/" + normalizedFile;
  QDir gpgIdDir(QFileInfo(fullPath).absoluteDir());
  bool found = false;
  while (gpgIdDir.exists() && gpgIdDir.absolutePath().startsWith(passStore)) {
    if (QFile(gpgIdDir.absoluteFilePath(".gpg-id")).exists()) {
      found = true;
      break;
    }
    if (!gpgIdDir.cdUp()) {
      break;
    }
  }
  QString gpgIdPath(found ? gpgIdDir.absoluteFilePath(".gpg-id")
                          : QtPassSettings::getPassStore() + ".gpg-id");

  return gpgIdPath;
}

/**
 * @brief Pass::getRecipientList return list of gpg-id's to encrypt for
 * @param for_file which file (folder) would you like recipients for
 * @return recipients gpg-id contents
 */
auto Pass::getRecipientList(const QString &for_file) -> QStringList {
  QFile gpgId(getGpgIdPath(for_file));
  if (!gpgId.open(QIODevice::ReadOnly | QIODevice::Text)) {
    return {};
  }
  QStringList recipients;
  while (!gpgId.atEnd()) {
    QString recipient(gpgId.readLine());
    recipient = recipient.split("#")[0].trimmed();
    if (!recipient.isEmpty()) {
      recipients += recipient;
    }
  }
  return recipients;
}

/**
 * @brief Pass::getRecipientString formatted string for use with GPG
 * @param for_file which file (folder) would you like recipients for
 * @param separator formating separator eg: " -r "
 * @param count
 * @return recipient string
 */
auto Pass::getRecipientString(const QString &for_file, const QString &separator,
                              int *count) -> QStringList {
  Q_UNUSED(separator)
  QStringList recipients = Pass::getRecipientList(for_file);
  if (count) {
    *count = recipients.size();
  }
  return recipients;
}

/* Copyright (C) 2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
 */

/**
 * @brief Generates a random number bounded by the given value.
 * @param bound Upper bound (exclusive)
 * @return Random number in range [0, bound)
 */
auto Pass::boundedRandom(quint32 bound) -> quint32 {
  if (bound < 2) {
    return 0;
  }

  quint32 randval;
  // Reject values below max_mod_bound (computed as 1 + ~bound == 2^32 -
  // bound) to avoid modulo bias and ensure uniform randval % bound.
  const quint32 max_mod_bound = (1 + ~bound) % bound;

  do {
    randval = QRandomGenerator::system()->generate();
  } while (randval < max_mod_bound);

  return randval % bound;
}

/**
 * @brief Generates a random password from the given charset.
 * @param charset Characters to use in the password
 * @param length Desired password length
 * @return Generated password string
 */
auto Pass::generateRandomPassword(const QString &charset, unsigned int length)
    -> QString {
  if (charset.isEmpty() || length == 0U) {
    return {};
  }
  QString out;
  for (unsigned int i = 0; i < length; ++i) {
    out.append(charset.at(static_cast<int>(
        boundedRandom(static_cast<quint32>(charset.length())))));
  }
  return out;
}

1	// SPDX-FileCopyrightText: 2016 Anne Jan Brouwer
2	// SPDX-License-Identifier: GPL-3.0-or-later
3	#include "pass.h"
4	#include "helpers.h"
5	#include "qtpasssettings.h"
6	#include "util.h"
7	#include <QDir>
8	#include <QFileInfo>
9	#include <QProcess>
10	#include <QRandomGenerator>
11	#include <QRegularExpression>
12	#include <utility>
13
14	#ifdef QT_DEBUG
15	#include "debughelper.h"
16	#endif
17
18	using Enums::GIT_INIT;
19	using Enums::GIT_PULL;
20	using Enums::GIT_PUSH;
21	using Enums::GPG_GENKEYS;
22	using Enums::PASS_COPY;
23	using Enums::PASS_INIT;
24	using Enums::PASS_INSERT;
25	using Enums::PASS_MOVE;
26	using Enums::PASS_OTP_GENERATE;
27	using Enums::PASS_REMOVE;
28	using Enums::PASS_SHOW;
29
30	/**
31	* @brief Pass::Pass wrapper for using either pass or the pass imitation
32	*/
33	Pass::Pass() : wrapperRunning(false), env(QProcess::systemEnvironment()) {	11✔
34	connect(&exec,	11✔
35	static_cast<void (Executor::*)(int, int, const QString &,
36	const QString &)>(&Executor::finished),
37	this, &Pass::finished);	11✔
38
39	// This was previously using direct QProcess signals.
40	// The code now uses Executor instead of raw QProcess for better control.
41	// connect(&process, SIGNAL(error(QProcess::ProcessError)), this,
42	// SIGNAL(error(QProcess::ProcessError)));
43
44	connect(&exec, &Executor::starting, this, &Pass::startingExecuteWrapper);	11✔
45	env.append("WSLENV=PASSWORD_STORE_DIR/p");	11✔
46	}	11✔
47
48	/**
49	* @brief Executes a wrapper command.
50	* @param id Process ID
51	* @param app Application to execute
52	* @param args Arguments
53	* @param readStdout Whether to read stdout
54	* @param readStderr Whether to read stderr
55	*/
56	void Pass::executeWrapper(PROCESS id, const QString &app,	×
57	const QStringList &args, bool readStdout,
58	bool readStderr) {
59	executeWrapper(id, app, args, QString(), readStdout, readStderr);	×
60	}	×
61
62	void Pass::executeWrapper(PROCESS id, const QString &app,	×
63	const QStringList &args, QString input,
64	bool readStdout, bool readStderr) {
65	#ifdef QT_DEBUG
66	dbg() << app << args;
67	#endif
68	exec.execute(id, QtPassSettings::getPassStore(), app, args, std::move(input),	×
69	readStdout, readStderr);
70	}	×
71
72	/**
73	* @brief Initializes the pass wrapper environment.
74	*/
75	void Pass::init() {	1✔
76	#ifdef __APPLE__
77	// If it exists, add the gpgtools to PATH
78	if (QFile("/usr/local/MacGPG2/bin").exists())
79	env.replaceInStrings("PATH=", "PATH=/usr/local/MacGPG2/bin:");
80	// Add missing /usr/local/bin
81	if (env.filter("/usr/local/bin").isEmpty())
82	env.replaceInStrings("PATH=", "PATH=/usr/local/bin:");
83	#endif
84
85	if (!QtPassSettings::getGpgHome().isEmpty()) {	2✔
86	QDir absHome(QtPassSettings::getGpgHome());	×
87	absHome.makeAbsolute();	×
88	env << "GNUPGHOME=" + absHome.path();	×
89	}	×
90	}	1✔
91
92	/**
93	* @brief Pass::Generate use either pwgen or internal password
94	* generator
95	* @param length of the desired password
96	* @param charset to use for generation
97	* @return the password
98	*/
99	auto Pass::generatePassword(unsigned int length, const QString &charset)	1,004✔
100	-> QString {
101	QString passwd;	1,004✔
102	if (QtPassSettings::isUsePwgen()) {	1,004✔
103	// --secure goes first as it overrides --no-* otherwise
104	QStringList args;	×
105	args.append("-1");	×
106	if (!QtPassSettings::isLessRandom()) {	×
107	args.append("--secure");	×
108	}
109	args.append(QtPassSettings::isAvoidCapitals() ? "--no-capitalize"	×
110	: "--capitalize");
111	args.append(QtPassSettings::isAvoidNumbers() ? "--no-numerals"	×
112	: "--numerals");
113	if (QtPassSettings::isUseSymbols()) {	×
114	args.append("--symbols");	×
115	}
116	args.append(QString::number(length));	×
117	// executeBlocking returns 0 on success, non-zero on failure
118	if (Executor::executeBlocking(QtPassSettings::getPwgenExecutable(), args,	×
119	&passwd) == 0) {
120	static const QRegularExpression literalNewLines{"[\\n\\r]"};	×
121	passwd.remove(literalNewLines);	×
122	} else {
123	passwd.clear();	×
124	#ifdef QT_DEBUG
125	qDebug() << __FILE__ << ":" << __LINE__ << "\t"
126	<< "pwgen fail";
127	#endif
128	// Error is already handled by clearing passwd; no need for critical
129	// signal here
130	}
131	} else {
132	// Validate charset - if CUSTOM is selected but chars are empty,
133	// fall back to ALLCHARS to prevent weak passwords (issue #780)
134	QString effectiveCharset = charset;
135	if (effectiveCharset.isEmpty()) {	1,004✔
136	effectiveCharset = QtPassSettings::getPasswordConfiguration()	2✔
137	.Characters[PasswordConfiguration::ALLCHARS];
138	}
139	if (effectiveCharset.length() > 0) {	1,004✔
140	passwd = generateRandomPassword(effectiveCharset, length);	2,008✔
141	} else {
142	emit critical(	×
143	tr("No characters chosen"),	×
144	tr("Can't generate password, there are no characters to choose from "	×
145	"set in the configuration!"));
146	}
147	}
148	return passwd;	1,004✔
149	}
150
151	/**
152	* @brief Pass::gpgSupportsEd25519 check if GPG supports ed25519 (ECC)
153	* GPG 2.1+ supports ed25519 which is much faster for key generation
154	* @return true if ed25519 is supported
155	*/
156	bool Pass::gpgSupportsEd25519() {	3✔
157	QString out, err;	3✔
158	if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(),	12✔
159	{"--version"}, &out, &err) != 0) {
160	return false;
161	}
162	QRegularExpression versionRegex(R"(gpg \(GnuPG\) (\d+)\.(\d+))");	×
163	QRegularExpressionMatch match = versionRegex.match(out);	×
164	if (!match.hasMatch()) {	×
165	return false;
166	}
167	int major = match.captured(1).toInt();	×
168	int minor = match.captured(2).toInt();	×
169	return major > 2 \|\| (major == 2 && minor >= 1);	×
170	}	3✔
171
172	/**
173	* @brief Pass::getDefaultKeyTemplate return default key generation template
174	* Uses ed25519 if supported, otherwise falls back to RSA
175	* @return GPG batch template string
176	*/
177	QString Pass::getDefaultKeyTemplate() {	1✔
178	if (gpgSupportsEd25519()) {	1✔
179	return QStringLiteral("%echo Generating a default key\n"	×
180	"Key-Type: EdDSA\n"
181	"Key-Curve: Ed25519\n"
182	"Subkey-Type: ECDH\n"
183	"Subkey-Curve: Curve25519\n"
184	"Name-Real: \n"
185	"Name-Comment: QtPass\n"
186	"Name-Email: \n"
187	"Expire-Date: 0\n"
188	"%no-protection\n"
189	"%commit\n"
190	"%echo done");
191	}
192	return QStringLiteral("%echo Generating a default key\n"	1✔
193	"Key-Type: RSA\n"
194	"Subkey-Type: RSA\n"
195	"Name-Real: \n"
196	"Name-Comment: QtPass\n"
197	"Name-Email: \n"
198	"Expire-Date: 0\n"
199	"%no-protection\n"
200	"%commit\n"
201	"%echo done");
202	}
203
204	namespace {
205	auto resolveWslGpgconfPath(const QString &lastPart) -> QString {	5✔
206	int lastSep = lastPart.lastIndexOf('/');	5✔
207	if (lastSep < 0) {	5✔
208	lastSep = lastPart.lastIndexOf('\\');	2✔
209	}
210	if (lastSep >= 0) {	2✔
211	return lastPart.left(lastSep + 1) + "gpgconf";	6✔
212	}
213	return QStringLiteral("gpgconf");	2✔
214	}
215
216	QString findGpgconfInGpgDir(const QString &gpgPath) {	1✔
217	QFileInfo gpgInfo(gpgPath);	1✔
218	if (!gpgInfo.isAbsolute()) {	1✔
219	return QString();
220	}
221
222	QDir dir(gpgInfo.absolutePath());	1✔
223
224	#ifdef Q_OS_WIN
225	QFileInfo candidateExe(dir.filePath("gpgconf.exe"));
226	if (candidateExe.isExecutable()) {
227	return candidateExe.filePath();
228	}
229	#endif
230
231	QFileInfo candidate(dir.filePath("gpgconf"));	1✔
232	if (candidate.isExecutable()) {	1✔
233	return candidate.filePath();	1✔
234	}
235	return QString();
236	}	1✔
237	} // namespace
238
239	namespace {
240	auto resolveWslGpgconf(const QStringList &parts) -> ResolvedGpgconfCommand {	7✔
241	if (parts.size() >= 2 && parts.at(1).startsWith("sh")) {	13✔
242	return {"gpgconf", {}};	1✔
243	}
244	for (int i = 1; i < parts.size(); ++i) {	10✔
245	const QString baseName = QFileInfo(parts.at(i)).fileName();	9✔
246	if (baseName == "gpg" \|\| baseName == "gpg.exe" \|\| baseName == "gpg2" \|\|	29✔
247	baseName == "gpg2.exe") {
248	QStringList newParts = parts;
249	newParts[i] = resolveWslGpgconfPath(parts.at(i));	10✔
250	return {newParts.first(), newParts.mid(1)};
251	}
252	}
253	return {"gpgconf", {}};	1✔
254	}	7✔
255	} // namespace
256
257	auto Pass::resolveGpgconfCommand(const QString &gpgPath)	10✔
258	-> ResolvedGpgconfCommand {
259	if (gpgPath.trimmed().isEmpty()) {	10✔
260	return {"gpgconf", {}};
261	}
262
263	#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
264	QStringList parts = QProcess::splitCommand(gpgPath);	9✔
265	#else
266	QStringList parts = QStringList{gpgPath};
267	#endif
268
269	if (parts.isEmpty()) {	9✔
270	return {"gpgconf", {}};
271	}
272
273	const QString first = parts.first();
274	if (first == "wsl" \|\| first == "wsl.exe") {	11✔
275	return resolveWslGpgconf(parts);	7✔
276	}
277
278	if (!gpgPath.contains('/') && !gpgPath.contains('\\')) {	2✔
279	return {"gpgconf", {}};
280	}
281
282	QString gpgconfPath = findGpgconfInGpgDir(gpgPath);	1✔
283	if (!gpgconfPath.isEmpty()) {	1✔
284	return {gpgconfPath, {}};	1✔
285	}
286
287	return {"gpgconf", {}};
288	}	3✔
289
290	/**
291	* @brief Pass::GenerateGPGKeys internal gpg keypair generator . .
292	* @param batch GnuPG style configuration string
293	*/
294	void Pass::GenerateGPGKeys(QString batch) {	×
295	// Kill any stale GPG agents that might be holding locks on the key database
296	// This helps avoid "database locked" timeouts during key generation
297	QString gpgPath = QtPassSettings::getGpgExecutable();	×
298	if (!gpgPath.isEmpty()) {	×
299	ResolvedGpgconfCommand gpgconf = resolveGpgconfCommand(gpgPath);	×
300	QStringList killArgs = gpgconf.arguments;
301	killArgs << "--kill";	×
302	killArgs << "gpg-agent";	×
303	// Use same environment as key generation to target correct gpg-agent
304	Executor::executeBlocking(env, gpgconf.program, killArgs);	×
305	}
306
307	executeWrapper(GPG_GENKEYS, gpgPath, {"--gen-key", "--no-tty", "--batch"},	×
308	std::move(batch));
309	}	×
310
311	/**
312	* @brief Pass::listKeys list users
313	* @param keystrings
314	* @param secret list private keys
315	* @return QList<UserInfo> users
316	*/
317	auto Pass::listKeys(QStringList keystrings, bool secret) -> QList<UserInfo> {	×
318	QList<UserInfo> users;	×
319	QStringList args = {"--no-tty", "--with-colons", "--with-fingerprint"};	×
320	args.append(secret ? "--list-secret-keys" : "--list-keys");	×
321
322	for (const QString &keystring : AS_CONST(keystrings)) {	×
323	if (!keystring.isEmpty()) {	×
324	args.append(keystring);
325	}
326	}
327	QString p_out;	×
328	if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(), args,	×
329	&p_out) != 0) {
330	return users;
331	}
332	#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
333	const QStringList keys =
334	p_out.split(Util::newLinesRegex(), Qt::SkipEmptyParts);	×
335	#else
336	const QStringList keys =
337	p_out.split(Util::newLinesRegex(), QString::SkipEmptyParts);
338	#endif
339	UserInfo current_user;	×
340	constexpr int GPG_MIN_FIELDS = 10;
341	constexpr int GPG_FIELD_VALIDITY = 1;
342	constexpr int GPG_FIELD_KEY_ID = 4;
343	constexpr int GPG_FIELD_CREATED = 5;
344	constexpr int GPG_FIELD_EXPIRY = 6;
345	constexpr int GPG_FIELD_USERID = 9;
346	for (const QString &key : keys) {	×
347	QStringList props = key.split(':');	×
NEW 348	if (props.size() < GPG_MIN_FIELDS) {	×
349	continue;
350	}
351	if (props[0] == (secret ? "sec" : "pub")) {	×
352	if (!current_user.key_id.isEmpty()) {	×
353	users.append(current_user);
354	}
355	current_user = UserInfo();	×
NEW 356	current_user.key_id = props[GPG_FIELD_KEY_ID];	×
NEW 357	current_user.name = props[GPG_FIELD_USERID].toUtf8();	×
NEW 358	current_user.validity = props[GPG_FIELD_VALIDITY][0].toLatin1();	×
NEW 359	bool okCreated = false;	×
360	const qint64 createdSecs =
361	props[GPG_FIELD_CREATED].toLongLong(&okCreated);
NEW 362	if (okCreated) {	×
NEW 363	current_user.created.setSecsSinceEpoch(createdSecs);	×
364	}
NEW 365	bool okExpiry = false;	×
366	const qint64 expirySecs = props[GPG_FIELD_EXPIRY].toLongLong(&okExpiry);
NEW 367	if (okExpiry) {	×
NEW 368	current_user.expiry.setSecsSinceEpoch(expirySecs);	×
369	}
370	} else if (current_user.name.isEmpty() && props[0] == "uid") {	×
NEW 371	current_user.name = props[GPG_FIELD_USERID];	×
NEW 372	} else if ((props[0] == "fpr") &&	×
NEW 373	props[GPG_FIELD_USERID].endsWith(current_user.key_id)) {	×
NEW 374	current_user.key_id = props[GPG_FIELD_USERID];	×
375	}
376	}
377	if (!current_user.key_id.isEmpty()) {	×
378	users.append(current_user);
379	}
380	return users;
381	}	×
382
383	/**
384	* @brief Pass::listKeys list users
385	* @param keystring
386	* @param secret list private keys
387	* @return QList<UserInfo> users
388	*/
389	auto Pass::listKeys(const QString &keystring, bool secret) -> QList<UserInfo> {	×
390	return listKeys(QStringList(keystring), secret);	×
391	}
392
393	/**
394	* @brief Pass::processFinished reemits specific signal based on what process
395	* has finished
396	* @param id id of Pass process that was scheduled and finished
397	* @param exitCode return code of a process
398	* @param out output generated by process(if capturing was requested, empty
399	* otherwise)
400	* @param err error output generated by process(if capturing was requested,
401	* or error occurred)
402	*/
403	void Pass::finished(int id, int exitCode, const QString &out,	×
404	const QString &err) {
405	auto pid = static_cast<PROCESS>(id);
406	if (exitCode != 0) {	×
407	emit processErrorExit(exitCode, err);	×
408	return;	×
409	}
410	switch (pid) {	×
411	case GIT_INIT:	×
412	emit finishedGitInit(out, err);	×
413	break;	×
414	case GIT_PULL:	×
415	emit finishedGitPull(out, err);	×
416	break;	×
417	case GIT_PUSH:	×
418	emit finishedGitPush(out, err);	×
419	break;	×
420	case PASS_SHOW:	×
421	emit finishedShow(out);	×
422	break;	×
423	case PASS_OTP_GENERATE:	×
424	emit finishedOtpGenerate(out);	×
425	break;	×
426	case PASS_INSERT:	×
427	emit finishedInsert(out, err);	×
428	break;	×
429	case PASS_REMOVE:	×
430	emit finishedRemove(out, err);	×
431	break;	×
432	case PASS_INIT:	×
433	emit finishedInit(out, err);	×
434	break;	×
435	case PASS_MOVE:	×
436	emit finishedMove(out, err);	×
437	break;	×
438	case PASS_COPY:	×
439	emit finishedCopy(out, err);	×
440	break;	×
441	case GPG_GENKEYS:	×
442	emit finishedGenerateGPGKeys(out, err);	×
443	break;	×
444	default:
445	#ifdef QT_DEBUG
446	dbg() << "Unhandled process type" << pid;
447	#endif
448	break;
449	}
450	}
451
452	/**
453	* @brief Pass::updateEnv update the execution environment (used when
454	* switching profiles)
455	*/
456	void Pass::updateEnv() {	×
457	// put PASSWORD_STORE_SIGNING_KEY in env
458	QStringList envSigningKey = env.filter("PASSWORD_STORE_SIGNING_KEY=");	×
459	QString currentSigningKey = QtPassSettings::getPassSigningKey();	×
460	if (envSigningKey.isEmpty()) {	×
461	if (!currentSigningKey.isEmpty()) {	×
462	// dbg()<< "Added
463	// PASSWORD_STORE_SIGNING_KEY with" + currentSigningKey;
464	env.append("PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);	×
465	}
466	} else {
467	if (currentSigningKey.isEmpty()) {	×
468	// dbg() << "Removed
469	// PASSWORD_STORE_SIGNING_KEY";
470	env.removeAll(envSigningKey.first());
471	} else {
472	// dbg()<< "Update
473	// PASSWORD_STORE_SIGNING_KEY with " + currentSigningKey;
474	env.replaceInStrings(envSigningKey.first(),	×
475	"PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);	×
476	}
477	}
478	// put PASSWORD_STORE_DIR in env
479	QStringList store = env.filter("PASSWORD_STORE_DIR=");	×
480	if (store.isEmpty()) {	×
481	// dbg()<< "Added
482	// PASSWORD_STORE_DIR";
483	env.append("PASSWORD_STORE_DIR=" + QtPassSettings::getPassStore());	×
484	} else {
485	// dbg()<< "Update
486	// PASSWORD_STORE_DIR with " + passStore;
487	env.replaceInStrings(store.first(), "PASSWORD_STORE_DIR=" +	×
488	QtPassSettings::getPassStore());	×
489	}
490	exec.setEnvironment(env);	×
491	}	×
492
493	/**
494	* @brief Pass::getGpgIdPath return gpgid file path for some file (folder).
495	* @param for_file which file (folder) would you like the gpgid file path for.
496	* @return path to the gpgid file.
497	*/
498	auto Pass::getGpgIdPath(const QString &for_file) -> QString {	8✔
499	QString passStore =
500	QDir::fromNativeSeparators(QtPassSettings::getPassStore());	16✔
501	QString normalizedFile = QDir::fromNativeSeparators(for_file);	8✔
502	QString fullPath = normalizedFile.startsWith(passStore)	8✔
503	? normalizedFile	8✔
504	: passStore + "/" + normalizedFile;	6✔
505	QDir gpgIdDir(QFileInfo(fullPath).absoluteDir());	8✔
506	bool found = false;
507	while (gpgIdDir.exists() && gpgIdDir.absolutePath().startsWith(passStore)) {	10✔
508	if (QFile(gpgIdDir.absoluteFilePath(".gpg-id")).exists()) {	2✔
509	found = true;
510	break;
511	}
512	if (!gpgIdDir.cdUp()) {	×
513	break;
514	}
515	}
516	QString gpgIdPath(found ? gpgIdDir.absoluteFilePath(".gpg-id")	8✔
517	: QtPassSettings::getPassStore() + ".gpg-id");	22✔
518
519	return gpgIdPath;	8✔
520	}	8✔
521
522	/**
523	* @brief Pass::getRecipientList return list of gpg-id's to encrypt for
524	* @param for_file which file (folder) would you like recipients for
525	* @return recipients gpg-id contents
526	*/
527	auto Pass::getRecipientList(const QString &for_file) -> QStringList {	5✔
528	QFile gpgId(getGpgIdPath(for_file));	5✔
529	if (!gpgId.open(QIODevice::ReadOnly \| QIODevice::Text)) {	5✔
530	return {};	×
531	}
532	QStringList recipients;	5✔
533	while (!gpgId.atEnd()) {	14✔
534	QString recipient(gpgId.readLine());	18✔
535	recipient = recipient.split("#")[0].trimmed();	18✔
536	if (!recipient.isEmpty()) {	9✔
537	recipients += recipient;
538	}
539	}
540	return recipients;
541	}	5✔
542
543	/**
544	* @brief Pass::getRecipientString formatted string for use with GPG
545	* @param for_file which file (folder) would you like recipients for
546	* @param separator formating separator eg: " -r "
547	* @param count
548	* @return recipient string
549	*/
550	auto Pass::getRecipientString(const QString &for_file, const QString &separator,	2✔
551	int *count) -> QStringList {
552	Q_UNUSED(separator)
553	QStringList recipients = Pass::getRecipientList(for_file);	2✔
554	if (count) {	2✔
555	*count = recipients.size();	1✔
556	}
557	return recipients;	2✔
558	}
559
560	/* Copyright (C) 2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
561	*/
562
563	/**
564	* @brief Generates a random number bounded by the given value.
565	* @param bound Upper bound (exclusive)
566	* @return Random number in range [0, bound)
567	*/
568	auto Pass::boundedRandom(quint32 bound) -> quint32 {	1,160✔
569	if (bound < 2) {	1,160✔
570	return 0;
571	}
572
573	quint32 randval;
574	// Reject values below max_mod_bound (computed as 1 + ~bound == 2^32 -
575	// bound) to avoid modulo bias and ensure uniform randval % bound.
576	const quint32 max_mod_bound = (1 + ~bound) % bound;	1,160✔
577
578	do {
579	randval = QRandomGenerator::system()->generate();
580	} while (randval < max_mod_bound);	1,160✔
581
582	return randval % bound;	1,160✔
583	}
584
585	/**
586	* @brief Generates a random password from the given charset.
587	* @param charset Characters to use in the password
588	* @param length Desired password length
589	* @return Generated password string
590	*/
591	auto Pass::generateRandomPassword(const QString &charset, unsigned int length)	1,004✔
592	-> QString {
593	if (charset.isEmpty() \|\| length == 0U) {	1,004✔
594	return {};
595	}
596	QString out;	1,003✔
597	for (unsigned int i = 0; i < length; ++i) {	2,163✔
598	out.append(charset.at(static_cast<int>(	1,160✔
599	boundedRandom(static_cast<quint32>(charset.length())))));	1,160✔
600	}
601	return out;
602	}

IJHack / QtPass / 24097698361

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous