kubernetes-sigs / karpenter / 24093431345

80%

main: 80%

Build Type

Pull #2951

github

Committed by jamesmt-aws

Commit Message

fix: use injected clock for minDrainTime check

The minDrainTime check in awaitDrain compared c.clock.Since() against
the condition's LastTransitionTime, which is set by operatorpkg using
metav1.Now() (real clock). When tests use a fake clock, the real clock
and fake clock diverge, causing the minDrainTime check to never pass.

Track drain start time using the injected clock via a sync.Map on the
controller. This matches the pattern from #2783 which fixed the same
class of real-clock-vs-fake-clock bug in other termination tests.

The test "should not finish draining until minDrainTime has passed"
failed deterministically on all k8s versions locally and on 1.35.x
in CI (timing-dependent on other versions).

Pull Request Pull Request #2951: fix: use injected clock for minDrainTime check

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

7 existing lines in 1 file now uncovered.

12171 of 15147 relevant lines covered (80.35%)

229142.82 hits per line