stacklok / toolhive / 24083390375

65%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(auth): extract transientRefresher and fix flaky singleflight test (#4497)

Fix flaky singleflight deduplication test with two-phase barrier

TestMonitoredTokenSource_SingleflightDeduplicatesConcurrentRetries was
non-deterministic: the singleflight leader could complete its retry and
return before follower goroutines reached refreshGroup.Do, causing them
to start independent retry loops and fail the call-count assertion.

Add beforeSingleflightEntry and afterSingleflightEntry test hooks (both
nil in production) to MonitoredTokenSource. The test uses a two-phase
barrier:

- Phase 1 (beforeSingleflightEntry): all goroutines rendezvous and are
  released simultaneously toward refreshGroup.Do.
- Phase 2 (afterSingleflightEntry): the leader waits inside Do until all
  goroutines have signalled they are about to call Do, guaranteeing the
  group is fully formed before the retry returns.

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Coverage Stats

46 of 51 new or added lines in 1 file covered. (90.2%)

18 existing lines in 5 files now uncovered.

54679 of 83911 relevant lines covered (65.16%)

61.57 hits per line