NodeBB / NodeBB / 24083175782

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix: use file.exists instead of try/catch to detect missing email logo (#14154)

The previous ENOENT check in getLogoSize never worked because image.size
passes the path directly to sharp, which throws a plain Error with message
"Input file is missing" rather than a Node.js ENOENT error. This caused
saving any admin settings to fail when brand:logo was set but the x50 file
was missing (e.g. after a fresh deployment).

Coverage Stats

13447 of 18455 branches covered (72.86%)

1 of 6 new or added lines in 1 file covered. (16.67%)

5 existing lines in 2 files now uncovered.

28404 of 33253 relevant lines covered (85.42%)

3337.87 hits per line