KarpelesLab / strtotime / 24080692262

81%

Build Type

push

github

Committed by MagicalTux

Commit Message

Consolidate tests into CSV and refactor code for clarity

Replace 20 scattered test files (4,300 lines) with a CSV-driven test suite:
- testdata/strtotime_tests.csv: 653 test cases sorted by expected timestamp
- testdata/strtotime_invalid.csv: 23 invalid input cases
- csv_test.go: single test runner with PHP cross-validation

Refactor library code for maintainability:
- Extract shared helpers (applyTimeOffset, stripWeekdayPrefix, parseOrdinalPrefix)
- Convert StrToTime from 340-line if/else chain to table-driven parser pipeline
- Merge duplicate parseNegativeYear/parsePositiveYear into parseSignedYear
- Hoist lookup maps (monthNames, unitMap) to package level
- Move lookup functions to lookups.go, DST/time helpers to helpers.go
- strtotime.go reduced from 1918 to 1532 lines

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

286 of 335 new or added lines in 5 files covered. (85.37%)

3 existing lines in 1 file now uncovered.

2697 of 3257 relevant lines covered (82.81%)

199.37 hits per line