Gallopsled / pwntools / 24073586667

74%

dev: 74%

Build Type

push

github

Committed by web-flow

Commit Message

Fix _build_date() crash on non-standard locale date strings (#2701)

* Fix _build_date() crash on non-standard locale date strings (#2513)

Some Android devices return locale-dependent strings in ro.build.date
(e.g. '2017年 11月 14日 星期二 09:55:07 CST' for Chinese locale) that
dateutil.parser.parse() cannot handle, causing wait_for_device() to
crash with a ParserError.

Fix: prefer ro.build.date.utc (integer epoch timestamp) which is
locale-independent and available on all Android devices. Fall back
to ro.build.date with error handling if the UTC property is missing.

* Add CHANGELOG entry for #2513 fix

* Simplify _build_date(): prefer ro.build.date.utc, keep minimal fallback

Address review: ro.build.date.utc is set by the AOSP build system
and available on all standard Android devices. Simplified comments
to reflect this is the primary path, with ro.build.date kept only
as a fallback for non-standard builds.

* Move CHANGELOG entry

* Fix Python 2.7 compatibility

* Disable intro doctest connecting to `ftp.ubuntu.com`

The FTP server is throttled in CI or just really slow. We already test the basic tcp tubes in the `remote` tests.

---------

Co-authored-by: coder999999999 <coder999999999@users.noreply.github.com>
Co-authored-by: peace-maker <peacemakerctf@gmail.com>

Coverage Stats

3813 of 6426 branches covered (59.34%)

0 of 14 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

13331 of 18128 relevant lines covered (73.54%)

0.74 hits per line