IgniteUI / igniteui-webcomponents / 24073187767

98%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(combo): overhaul selection, data pipeline, and component architecture (#2164)

* refactor(combo): overhaul selection, data pipeline, and component architecture

Major refactoring of the `IgcComboComponent` and its supporting infrastructure
to improve maintainability, correctness, and adherence to project conventions.

- `combo.ts`
- Inherits from `IgcBaseComboBoxComponent` instead of bare `LitElement`, sharing
  open/close lifecycle (`_show`, `_hide`) with picker components.
- Removed the `SelectionController` — selection state (`_selected: Set<T>`) is now
  managed directly inside the component for a simpler, single-source-of-truth model.
- Replaced `@watch('open')` decorator with `willUpdate()` lifecycle hook.
- Replaced `@queryAssignedElements` with `addSlotController` / `setSlots` for slot
  detection (no more `inputPrefix` / `inputSuffix` public properties).
- Form value serialization moved into the `setFormValue` transformer on
  `createFormValueState` — removes the separate `_setFormValue()` override.
- `_setDefaultValue` now handles invalid JSON gracefully instead of throwing.
- `firstUpdated` removed; initialization is handled by `willUpdate` / `willUpdate`
  data-sync guard for the delayed-data scenario.
- Added `_syncSelectionFromValue()` (value → Set) and `_syncValueFromSelection()`
  (Set → form value) for explicit one-way data flow.
- Added `_resolveItems()`, `_resolveItemValue()`, `_getValues()` private helpers.
- All internal render helpers and event handlers renamed to `_camelCase` convention
  (e.g., `renderMainInput` → `_renderMainInput`, `handleMainInput` → `_handleMainInput`).
- `groupKey` / `groupSorting` setters removed — now simple `@property` declarations;
  pipeline invalidation driven by `willUpdate`.
- `filteringOptions` and `disableFiltering` setters simplified.
- `label` and `placeholder` changed from `!` non-null asserted to optional (`?`).
- `placeholderSearch` setter typed as `string | undefined`.
- Added `Ite... (continued)

Coverage Stats

5549 of 5831 branches covered (95.16%)

Branch coverage included in aggregate %.

927 of 941 new or added lines in 26 files covered. (98.51%)

1 existing line in 1 file now uncovered.

39192 of 39638 relevant lines covered (98.87%)

1503.44 hits per line