visgl / deck.gl / 24060053095

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(widgets): Add controlled mode and state callbacks (#9973)

* feat(widgets): Add controlled mode and state callbacks to widgets

Implement controlled/uncontrolled component pattern for 12 widgets (ThemeWidget, FullscreenWidget, TimelineWidget, ZoomWidget, CompassWidget, GimbalWidget, GeocoderWidget, ResetViewWidget, ViewSelectorWidget, SplitterWidget, StatsWidget, LoadingWidget). Add state props, getter methods, and callbacks. Update widget overview documentation with controlled/uncontrolled mode explanation.

Closes #9964

Co-Authored-By: Claude (global.anthropic.claude-haiku-4-5-20251001-v1:0) <noreply@anthropic.com>

* fix(widgets): Address PR review feedback

- Remove redundant _playing assignments in timeline-widget start()/stop()
- Remove redundant updateHTML() calls after super.setProps() in multiple widgets
- Fix IconMenu to support controlled mode via selectedItem prop

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(widgets): Address PR review feedback on callback naming

- Rename onCompassReset -> onReset (CompassWidget)
- Rename onGimbalReset -> onReset (GimbalWidget)
- Rename defaultIsExpanded -> initialExpanded (StatsWidget, aligns with initial* convention)
- Rename collapsed/onCollapsedChange -> expanded/onExpandedChange (StatsWidget, positive flag)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(widgets): Fix Timeline sync and controlled mode guards in TimelineWidget

- play() now respects controlled time mode by guarding internal state update
- tick() now syncs Timeline object in uncontrolled mode
- setProps() now syncs Timeline object when controlled time prop changes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(widgets): Fix Timeline sync and controlled mode guards in TimelineWidget

- Fix pseudo-fullscreen path in FullscreenWidget not updating state/UI
  (no fullscreenchange event fires, so manually sync state and re-render)
- Fix controlled playing mode infinite timer loop in T... (continued)

Coverage Stats

3171 of 3773 branches covered (84.04%)

Branch coverage included in aggregate %.

75 of 103 new or added lines in 10 files covered. (72.82%)

3 existing lines in 3 files now uncovered.

14484 of 17907 relevant lines covered (80.88%)

26623.68 hits per line