visgl / deck.gl / 24053792192

82%

push

github

fix(mapbox): automatically inject 'mapbox' view in overlaid mode for multi-view consistency (#9947)

* fix(mapbox): automatically inject 'mapbox' view in overlaid mode for multi-view consistency

When custom views are provided without a view with id 'mapbox', MapboxOverlay
now automatically injects the default 'mapbox' view in overlaid mode, matching
the behavior in interleaved mode (where getViewport() already does this fallback).

This ensures consistent behavior between interleaved and overlaid modes, and
allows users to only specify additional views (like minimap, ortho) without
having to manually include the base map view.

The bug was discovered while implementing multi-view examples in #9946. When
interleaved was false (overlaid mode), the multi-view example did not render
airports/arcs layers because there was no 'mapbox' view for them to render in.
In interleaved mode, the same example worked because getViewport() in deck-utils
falls back to creating a 'mapbox' view when not found in custom views.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* docs(mapbox): clarify multi-view behavior and add tests for view injection

- Improved multi-view documentation to explain automatic 'mapbox' view injection
- Added 6 test cases covering view injection in both overlaid and interleaved modes
- Tests verify that 'mapbox' view is auto-injected when not provided and that no duplicates are created when explicitly provided

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(mapbox): ensure consistent view injection in both modes

- Updated setProps() to call _getViews() for both overlaid and interleaved modes
- Added _getViews() call in _onAddInterleaved() to inject 'mapbox' view at initialization
- Updated _handleStyleChange() to always update views on projection change, even with custom views
- Extended AutoInjectMapboxView tests to verify setProps maintains view injection in both modes

This ensures both overlaid and interleave... (continued)

3121 of 3771 branches covered (82.76%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 2 files covered. (100.0%)

14302 of 17905 relevant lines covered (79.88%)

26596.35 hits per line