bluesky / hklpy2 / 24053794983

100%

push

github

maint: address CodeQL findings (#278)

* maint remove unused local variables (CodeQL findings)

Remove unused local variables flagged by CodeQL static analysis:
- lattice.py: split chained assignment to avoid intermediate unused names
- test_lattice.py: drop _lat = prefix where constructor result is unused

Agent: OpenCode (claudesonnet46)

* maint add noqa: F401 to TYPE_CHECKING-guarded imports (CodeQL findings)

Imports under TYPE_CHECKING guards are used only in string annotations to
avoid circular imports at runtime. Static analysis flags them as unused
since the annotation uses the quoted form. Add '# noqa: F401' to suppress
the false-positive in misc.py, ops.py, and reflection.py.

Agent: OpenCode (claudesonnet46)

* maint fix mixed explicit/implicit returns and return-type annotations (CodeQL)

- hkl_soleil.py: bare 'return' -> 'return None' in calculate_UB(); update
  return type to Matrix3x3 | None; add Returns docstring section
- th_tth_q.py: add 'return []' fall-through in modes property; update
  refineLattice return type to NamedFloatDict | None
- base.py, no_op.py: update refineLattice return type to NamedFloatDict | None
- ops.py: guard against None from refineLattice() with a clear CoreError
- user.py: add explicit 'return None' and update annotation to Table | None
  in solver_summary()
- hkl_soleil-python_api.py: remove unused GLib import

Agent: OpenCode (claudesonnet46)

* maint fix loop variables defined multiple times (CodeQL findings)

- ops.py: rename overwritten loop var 'refl' to 'refl_obj'/'refl_dict'
  in _reflections_to_solver()
- user.py: rename overwritten loop var 'r' to 'pseudos' in cahkl_table()
- test_backends.py, test_sample.py, test_diffract.py: remove unused
  variable assignments flagged as defined multiple times

Agent: OpenCode (claudesonnet46)

* maint fix modification of parameters with mutable defaults (CodeQL findings)

- diffract.py scan_extra(): change extras default from {} to None; make
  local copy wit... (continued)

87 of 87 new or added lines in 21 files covered. (100.0%)

6365 of 6365 relevant lines covered (100.0%)

4.0 hits per line