dennisdoomen / fluentassertions / 24040157145

97%

develop: 97%

Build Type

push

github

Committed by dennisdoomen

Commit Message

fix: GetFailureCount includes nested scope failures; add Discard() to prevent outer scope contamination

TryToMatchCount creates a dry-run AssertionScope with SkipFormattingForFailures=true.
When custom equivalency rules (e.g. Using<T>().WhenTypeIs<T>()) are applied, failures
go through AssertionRuleEquivalencyStep which wraps execution in its own inner scope.
Those inner-scope failures propagate to the dry-run scope's assertionStrategy.FailureMessages
rather than via CountFailure(), so GetFailureCount() was returning 0 for all pairs
(both matching and non-matching), causing incorrect Phase 1 match decisions and
wrong item pairing (e.g. in Should_methods_have_a_matching_overload test).

Fixes:
1. GetFailureCount() now returns failureCount + assertionStrategy.FailureMessages.Count()
   to capture both direct failures and failures propagated from nested scopes.
2. scope.Discard() added after GetFailureCount() in TryToMatchCount to prevent the
   accumulated failure messages from leaking to the outer BeEquivalentTo scope when
   the dry-run scope disposes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

4041 of 4314 branches covered (93.67%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 5 files covered. (100.0%)

1 existing line in 1 file now uncovered.

13092 of 13316 relevant lines covered (98.32%)

66799.45 hits per line