ThePalaceProject / web-patron / 24036291792

88%

push

github

Use only `rel="authenticate"` links for authentication settings (#113)

## Description

Fixes potential app startup crash when SAML authentication document
includes a `rel="logout"` link alongside the `rel="authenticate"` link.
`serverToClientSamlMethods` was mapping over all links indiscriminately;
the `rel="logout"` link has no `display_names`, causing a `TypeError` at
startup.

## Motivation and Context

Libraries using SAML auth with a `rel="logout"` link in their
authentication document would fail to load with `TypeError: Cannot read
properties of undefined...`.

## How Has This Been Tested?

- Added a unit test covering a SAML method with both
`rel="authenticate"` and `rel="logout"` links.
- All existing tests continue to pass.
- Verified against a local Circulation Manager returning the affected
auth document structure.

## Checklist:

- [x] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

76 of 94 branches covered (80.85%)

Branch coverage included in aggregate %.

92 of 113 relevant lines covered (81.42%)

11.19 hits per line