hyperledger / fabric-x-committer / 24032798069

92%

Build Type

push

github

Committed by web-flow

Commit Message

[mock] fix flaky TestOrderer by making CutBlock synchronous (#504)

#### Type of change

- Test update
 
#### Description

Root cause: The inEnvs channel is buffered, so SubmitEnv returns
immediately without the Run goroutine having processed the envelope.
When CutBlock (unbuffered) is called next, Go's select may pick the
cutBlock case before the inEnvs case, causing sendBlockData to operate
on empty data — no block is created and the test hangs.

Fix: Make CutBlock synchronous using a Ready channel so it blocks until
the cut completes. The cutBlock handler drains all buffered envelopes
before cutting, and since CutBlock now blocks the caller, no new
envelopes can be submitted during the drain.

#### Related issues

 - resolves #502

Signed-off-by: Senthilnathan <cendhu@gmail.com>

Coverage Stats

19 of 21 new or added lines in 1 file covered. (90.48%)

31 existing lines in 7 files now uncovered.

10025 of 10945 relevant lines covered (91.59%)

42430.91 hits per line