source-academy / frontend / 24028587983

41%

Build Type

push

github

Committed by web-flow

Commit Message

Animation for Clear Dead Frames button (#3726)

* Added the removeDeadFrames feature
Only dead frames disappear as of right now, for function objects and the rest, work to be done

Animations : will be done by Keying!

* Added the functionality for toggle of dead vs ONLY live for
	function closure objects
	Generic Arrow
	Text (recursively automated)
	Arrays and hence pairs as well

* Fix : Removed gaps
Finally processed the logic by recomputing the envTree for the specific step when the toggle is on

* Fix : CI format errors and made it from checkbox -> onClick button!

* Fix : Toggle -> One time cleanup

* Changed from Hide -> Clear and the icon

* WIP logic for Clear Dead Frames animation

Currently, the animations do not play.

Putting these changes into a branch because I want to save these changes so that I can fully rewrite playClearDeadFramesAnim() while having a backup in case my new idea does not work.

* Frames have a shifting animation now

After clicking Clear Dead Frames, frames that get shifted (to close gaps) now have an animation moving from their old position to their new position.

To do:
- animate other objects, not just frames
- possibly cover up the "new frames" before the animation finishes

* "New frames" are covered up

Now you cannot see the new frames before the frame shifting animation finishes.

Test code (for my own easy access):
function foo() {
    function f(x) {
        return y => x + 3;
    }
    return f;
}
foo()(4);
foo()(5);

To do:
- Make frame text (from bindings) move with the frame. This should be implemented with AnimatedTextComponent rather than AnimatedTextbox because there are multiple bindings per frame and the texts are linked to each binding rather than its frame.
- Consider whether the frame's name (text) should move along with the frame.
- Consider whether arrows should be animated (likely not, as the arrows can change shape so it might look weird / be hard to implement).
- Move function objects and a... (continued)

Coverage Stats

2301 of 6627 branches covered (34.72%)

Branch coverage included in aggregate %.

11 of 235 new or added lines in 10 files covered. (4.68%)

2 existing lines in 2 files now uncovered.

5847 of 13168 relevant lines covered (44.4%)

28.44 hits per line