Freegle / iznik-server-go / 88566b32-98b4-43c1-a7cc-19e88fe99e7f

77%

master: 89%

Pull #63

circleci

fix(membership): banned list shows V1 bans and isolates by group

V1 PHP stores bans in users_banned only (memberships row deleted).
Go API stored bans in memberships.collection='Banned' only.

Two bugs resulted:
1. filter=5 (Banned list) showed empty for mods whose members were
   banned via V1, since the query only checked memberships.
2. Members appeared in multiple groups' banned lists when legacy
   global ban data created memberships.collection='Banned' across
   all groups (no users_banned row scoped to specific group).

Fix:
- Ban action now writes to BOTH memberships AND users_banned (V1 parity)
- Unban action deletes from BOTH tables
- Unban-on-rejoin (PutMemberships) checks BOTH tables, clearing both
- filter=5 query uses UNION ALL: branch 1 selects from users_banned
  (group-specific, authoritative) for V1 and new Go bans; branch 2
  selects legacy Go-only memberships rows (NOT EXISTS guard prevents
  duplicates). ORDER BY (bandate IS NULL), bandate DESC so real dates
  sort above undated legacy entries.

Tests added:
- TestBannedListShowsV1StyleBan: V1-style ban appears in filter=5
- TestBannedListIsolatedByGroup: ban in group A absent from group B
- TestBanActionWritesUsersBanned: Ban API writes users_banned, bandate shown

Fixes Discourse topic #9553 post #4

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

47 of 51 new or added lines in 1 file covered. (92.16%)

19594 of 25587 relevant lines covered (76.58%)

23.35 hits per line