umputun / revdiff / 24026274635

90%

Build Type

push

github

Committed by web-flow

Commit Message

Address external code review findings (#34)

* add plan: review-findings

* feat: route annotation list keys through keymap

Replace hardcoded j/k/up/down strings in handleAnnotListKey with
keymap.Resolve() ActionDown/ActionUp so remapped keys work in the
annotation list popup. Enter stays hardcoded (modal convention),
esc uses hybrid pattern matching handleHelpKey.

* feat: return error from Keymap.Dump() instead of discarding

* feat: refactor handleThemes to return (bool, error) instead of os.Exit

Accept io.Writer params for testability, remove os.Exit calls,
unify color field mapping via colorFieldPtrs(), use early continue
in applyTheme loop.

* fix: address Copilot review findings

Handle modal enter/esc before keymap navigation in annotation list
to prevent remapping conflicts. Use valid hex colors and t.TempDir()
in tests.

Coverage Stats

78 of 94 new or added lines in 4 files covered. (82.98%)

57 existing lines in 3 files now uncovered.

3912 of 4264 relevant lines covered (91.74%)

460.3 hits per line