dblock / grape / 24016385370

97%

master: 97%

push

github

Fix UnknownAuthStrategy raised when custom auth strategy inherits from Grape::Middleware::Auth::Base

When a custom auth strategy class inherits from Grape::Middleware::Auth::Base
and is registered via Grape::Middleware::Auth::Strategies.add, it would raise
Grape::Exceptions::UnknownAuthStrategy with a blank strategy name upon being
instantiated by StrategyInfo#create.

The root cause: PR #2563 moved the strategy lookup from request-time (_call)
to initialization-time (initialize). When StrategyInfo#create instantiates
the custom class via auth_class.new(app) (without options), the inherited
initialize tries to look up options[:type] which is nil, causing the error.

The fix: guard the strategy lookup so it only runs when :type is present in
options. This preserves compile-time validation for the outer middleware
wrapper while allowing subclasses to be instantiated as actual strategies.

Fixes #2669.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

1073 of 1164 branches covered (92.18%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

3349 of 3405 relevant lines covered (98.36%)

33087.89 hits per line