Alan-Jowett / sonde / 23982967707

81%

push

github

node: restore 400ms/200ms WAKE retry timing for USB-CDC modem bridge (#648)

* fix(ci): remove invalid job-level matrix conditional

The job-level \if\ referenced \matrix.os\, which is not available
at job level — GitHub Actions evaluates job \if\ before expanding
the strategy matrix. This broke CI on main.

Remove the condition entirely. macOS runners are free for public
OSS repositories, so the cost optimization is unnecessary.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* node: restore 400ms/200ms WAKE retry timing for USB-CDC modem bridge

Commit 28a547f reverted the retry delay and response timeout to
100ms/50ms to match the spec, but the spec itself was wrong — those
values are too tight for the USB-CDC modem bridge round-trip path
(node -> ESP-NOW -> modem -> USB-CDC -> gateway -> USB-CDC -> modem ->
ESP-NOW -> node).

Restore the values from commit 332204b and update the spec docs
(protocol.md, node-requirements.md ND-0700/ND-0701/ND-0702,
node-design.md §4.2/§4.3, node-validation.md T-N700/T-N702/T-N936/
T-N937) to match:

- \RETRY_DELAY_MS\: 100 -> 400 ms
- \RESPONSE_TIMEOUT_MS\: 50 -> 200 ms

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review: fix timing ambiguity, rename MAX_RETRIES, update send_recv default

- Rename WAKE_MAX_RETRIES → MAX_RETRIES since it is shared by both
  WAKE/COMMAND and GET_CHUNK exchanges; update doc comment to cite
  ND-0700/ND-0701/ND-0702.
- Update SEND_RECV_TIMEOUT_MS from 50 ms → 200 ms to match the
  transport-appropriate timeout (same USB-CDC bridge latency applies).
- Clarify spec, requirements, and validation docs to distinguish the
  400 ms backoff delay (RETRY_DELAY_MS) from the total inter-transmission
  interval (~600 ms = 200 ms response timeout + 400 ms backoff).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review round 2: clarify design docs, record recv timeouts in tests

- node-design.md §4.2: reword... (continued)

18 of 18 new or added lines in 2 files covered. (100.0%)

20037 of 24727 relevant lines covered (81.03%)

146.12 hits per line