Alan-Jowett / sonde / 23980109370

81%

main: 81%

Build Type

push

github

Committed by web-flow

Commit Message

fix: always initialize HandlerRouter from DB (GW-1407) (#643)

* fix: always initialize HandlerRouter from DB (GW-1407)

DB-stored handlers added via `sonde-admin handler add` were never
wired to the gateway engine's `HandlerRouter`. The router was only
created when `--handler-config` was provided, so `handle_app_data_core()`
returned `None` at `self.handler_router.as_ref()?` and APP_DATA frames
were silently dropped.

Changes:

**Requirements** (gateway-requirements.md):
- Add GW-1407: gateway MUST always initialize `HandlerRouter` from
  DB at startup, wrapped in `Arc<tokio::sync::RwLock<HandlerRouter>>`
  shared between engine and admin service.
- Add GW-1404 AC5: `ImportState` MUST trigger live reload.
- Add GW-1405 AC5: after bootstrap, router built from DB (YAML is seed).

**Design** (gateway-design.md):
- Update D-485 shared-state pattern to include `HandlerRouter`.
- Update startup sequence steps 6-7 to reference GW-1407.
- Add `ImportState` as a reload trigger in section 19.5.
- Fix pre-existing cross-reference errors (18.6->19.6, 18.5->19.5).

**Implementation**:
- `handler.rs`: add `PartialEq` for `HandlerConfig`/`ProgramMatcher`,
  add `HandlerRouter::reload()` (diffs configs, reuses unchanged
  processes, gracefully shuts down removed handlers with 5s timeout),
  add `HandlerProcess::graceful_shutdown()`.
- `engine.rs`: change `handler_router` from `Option<Arc<HandlerRouter>>`
  to `Arc<tokio::sync::RwLock<HandlerRouter>>`. Update constructors,
  remove `set_handler_router()`. All routing acquires read lock.
- `admin.rs`: add shared router field + `with_handler_router()` builder.
  `reload_handler_configs()` now live-reloads the shared router.
  `import_state` triggers reload after replacing handlers (GW-1404 AC5).
- `gateway.rs`: unified startup — bootstrap YAML to DB first if
  provided, then always build router from DB. Pass shared router to
  both `Gateway` and `AdminService`.

**Validation** (gateway-validation.md, e2e-validation.md)... (continued)

Run Details

47 of 185 new or added lines in 5 files covered. (25.41%)

18 existing lines in 3 files now uncovered.

19676 of 24367 relevant lines covered (80.75%)

148.18 hits per line