keplergl / kepler.gl / 23979855808

60%

push

github

[Bug] Fix boolean parsing for yes/no string values (#3346) (#3365)

When loading GeoJSON data containing boolean fields with "yes"/"no"
string values, type-analyzer correctly classifies the field as boolean,
but the kepler.gl parse function only recognized "true"/"True"/"TRUE"/"1"
as truthy. This caused all "yes" values to be incorrectly parsed as false.

Align the boolean parse function with type-analyzer's boolean recognition
by using case-insensitive comparison via String.toLowerCase(). The parser
now correctly handles "yes"/"Yes"/"YES" as true and "no"/"No"/"NO" as
false, matching the BOOLEAN_TRUE_VALUES and BOOLEAN_FALSE_VALUES defined
in type-analyzer.

Also expand boolean test coverage to include yes/no variants and
additional case combinations (TRUE, false, FALSE).

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

6516 of 12976 branches covered (50.22%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

13314 of 20144 relevant lines covered (66.09%)

78.44 hits per line