dcdpr / jp / 23977385715

67%

push

github

feat(cli): Process `--tool`/`--no-tool` flags left-to-right (#513)

Previously, `--tool` and `--no-tools` values were collected into
separate vecs and applied in a fixed order: disable-all > enable-all >
enable-named > disable-named. The position of flags on the command line
had no effect, making interleaved usage like `--tool=write --no-tools
--tool=read` surprising and unexpressive.

This implements RFD-008 by introducing a `ToolDirective` enum and a
`ToolDirectives` struct that preserves flag order using
`ArgMatches::indices_of`. `apply_enable_tools` now iterates directives
sequentially, enabling precise tool composition:

    # Start from nothing, add only what you need
    jp q --no-tools --tool=write

    # Start from everything, carve out exceptions
    jp q --tools --no-tool=dangerous_tool

The former restriction against combining bare `--no-tool` with bare
`--tool` is removed, since ordered evaluation makes that well-defined.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

68 of 110 new or added lines in 1 file covered. (61.82%)

19908 of 31015 relevant lines covered (64.19%)

321.67 hits per line