sebnitu / vrembem / 23972730293

89%

main: 100%

push

github

Improve the popover component and config module integration (#2744)

This PR primarily refactors the popover component to the new CSS variable pattern and config module integration. This pattern applies CSS variable references along with sensible fallbacks replacing the initial Sass variable solution for component customization. The documentation has also been updated to reflect these changes.

An additional API refactor this PR introduces is the renaming of `virtual` config option to `followCursor`. This better describes what this options does and further renames internal logic to more clearly describe the methods and variables this feature tracks.

Lastly, this PR also refactors and expands the private store module to now use WeakMaps as well as Symbols for storing private data of both collections and their entries. This has been made proxy friendly by storing the root reference of entries using symbols as the property key. All JS components have been updated to use private store where applicable. 

**Additional changes**

- `core`: `EventEmitter` has been refactored to use Maps instead of a generic object for managing stored events and their listeners.
- `Drawer`: Moved private (`#`) event handler refs into private store.
- `Modal`: Moved private (`#`) event handler refs into private store.
- `Notice`: Fixed broken notice title styles.
- `Popover`: Improved logic of `getDelay` helper.
- `Popover`: Removed custom events in favor of event system.
- `Popover`: Improved config types by allowing for more inference where possible and using floating-ui types where applicable, such as the `Padding` type.
- `docs`: Fixed a bug in `ReferenceTable` component where the height of the header was not being added for expandable tables.
- `docs`: Updated singular var name of popover collection to plural.

585 of 666 branches covered (87.84%)

Branch coverage included in aggregate %.

95 of 101 new or added lines in 14 files covered. (94.06%)

935 of 1001 relevant lines covered (93.41%)

31.98 hits per line