KarpelesLab / slirp / 23950819644

71%

Build Type

push

github

Committed by MagicalTux

Commit Message

Fix 28 bugs: protocol correctness, race conditions, resource leaks

vtcp/conn.go:
- Fix OOO FIN causing premature state transition and data loss
- Send timestamps on all segments after negotiation (RFC 7323)
- Send SACK blocks in ACKs when OOO data exists (RFC 2018)
- Fix fast recovery exit using correct recovery point sequence
- Respect configured congestion control in handleSynSent
- Account for OOO data in rcvWindow (use RecvBuf.Window)
- Fix keepalive initial timer (use idle timeout, not probe interval)
- Enforce write deadlines in Write() matching Read() pattern
- Use configured send buffer size in AcceptSYN/SetupForHandshake
- Remove duplicate stopPersist() call in RST handling

vtcp/congestion.go:
- Track recovery point (sndNxt) for correct fast recovery exit
- Add RecoverySeq() to CongestionController interface

vtcp/sendbuf.go:
- Add SACK scoreboard: MarkSACKed, IsSACKed, prune on ACK
- RetransmitData skips SACK'd ranges

tcp_nat.go:
- Replace plain bool with sync.Once for goroutine-safe close

usernat.go + ipv6.go:
- Fix SYN retransmit race with pending-connection tracking
- Fix RST generation per RFC 9293 §3.10.7.1
- Abort vtcp.Conn on listener accept overflow instead of silent drop
- Skip TIME_WAIT in maintenance (let vtcp timer handle transition)
- Validate IPv6 payload length against actual packet
- Skip IPv6 extension headers to find transport protocol

vclient/udp.go:
- Fix Read/Close race condition (closedForRead under recvMu)
- Implement read deadlines with timer-based wakeup
- Validate UDP length field, trim payload accordingly

vclient/client.go: Port collision detection in allocPort
vclient/arp.go: Clean up ARP waiters on timeout/cancel/error
vclient/tcp.go: Abort on accept overflow; reject SYN+ACK
vclient/dns.go: Replace time.After with time.NewTimer
vtcp/nettest/stress_test.go: Fix data races (atomic operations)
README.md: Update stale documentation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

148 of 399 new or added lines in 11 files covered. (37.09%)

21 existing lines in 7 files now uncovered.

3044 of 4275 relevant lines covered (71.2%)

11769.97 hits per line