DanielXMoore / Civet / 23950662260

95%

push

github

Fix shorthand @ in destructuring assignments to use this.x directly (#1901)

In assignment (non-binding) contexts, `this.x` is a valid assignment target,
so `[@spot] = arr` can transpile to `[this.spot] = arr` instead of the
boilerplate `let spot; [spot] = arr, this.spot = spot`.

Changes:
- `adjustAtBindings`: fix early `return` that prevented processing multiple
  AtBindingProperty nodes (e.g., `{@a, @b} = c` only handled `@a` before).
  Also use `splice(1, 0, ...)` instead of `unshift` to preserve leading whitespace.
- `processBindingPatternLHS`: after handling AtBindingProperty shorthand,
  also convert remaining AtBinding nodes (array positions, explicit key: @x)
  to `this.x` member expressions directly. Also updates blockPrefixes that
  reference these AtBinding refs (for rest element cases like `[...@x, y]`),
  and handles AtBindings inside blockPrefixes (post-rest like `[a, ..., @x]`).

Fixes #257

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Daniel X Moore <STRd6@users.noreply.github.com>

5928 of 6296 branches covered (94.16%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 2 files covered. (100.0%)

24838 of 26791 relevant lines covered (92.71%)

36768.47 hits per line